-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional moment calculation #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malihass, everything looks good on my end. Shame about the _tf_generate()
vs. _tf_generate_wind()
methods, i'm assuming you did this because of the multi-class inheritance conflict? Good solution but still a shame it couldnt be cleaner haha.
I'm approving but I still want @bnb32 to get a chance to look at the updates to the batch handling before you merge.
Is there really not a way to override that method with multi class inheritance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks! I just have some questions about the inheritance stuff and whether we can avoid the _wind suffix work around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_wind seems like the best solution since WindGan also inherits this stuff. Good work!
Conditional moment calculation
Sup3rCondMom
andWindCondMom
which do not include the discriminator detailsoutput
andmask
on top oflow_res
high_res
. This is useful because sometime thehigh_res
may not be directly obtainable from the output we are learning. The mask is useful if padding needs to be used.