Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
calc_loss
function should not be atf.function
since its behavior changes depending on whether discriminator or generator, or both are trained.With the
tf.function
on, function retracing occurs (we see messages likeWARNING:tensorflow:5 out of the last 18 calls to <function Sup3rGan.calc_loss at 0x7facf82f8290> triggered tf.function retracing...
).With
tf.function
off, no retracing occurs. I could also see a small speed up when running on my machine.To reproduce results, run the following snippet in
tests/