Bnb/dev #101
Merged
Bnb/dev #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantbuster
requested changes
Oct 12, 2022
| arr = np.expand_dims(arr, axis=(0, 2, 3)) | ||
| arr = np.repeat(arr, hgt.shape[0], axis=0) | ||
| arr = np.repeat(arr, hgt.shape[2], axis=2) | ||
| arr = np.repeat(arr, hgt.shape[3], axis=3) |
There was a problem hiding this comment.
is this where the pressure level magic happens? Looks great, this is exactly why i reached out for help :)
There was a problem hiding this comment.
Yeah, all we needed to do was setup the plev field to be treated like any other field that needs height interpolation. So we make it into a 4D array (it starts as just a 1D) and we're good to go.
This can be accomplished by the ordering in the feature registry but I also added an explicit loop for this. |
grantbuster
approved these changes
Oct 12, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
non surface feature handling for cc data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added non surface features for DataHandlerNCforCC