feat: Missing opportunity at local_qdm_bc() to define threshold

Before it would necessarily only use the default.
NREL · Apr 18, 2024 · 3c35869 · 3c35869
1 parent fd8f2f0
commit 3c35869
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/sup3r/bias/bias_transforms.py b/sup3r/bias/bias_transforms.py
@@ -403,6 +403,7 @@ def local_qdm_bc(data: np.array,
  base_dset: str,
  feature_name: str,
  bias_fp,
+ threshold=0.1,
  relative=True,
  no_trend=False):
  """Bias correction using QDM
@@ -482,7 +483,8 @@ def local_qdm_bc(data: np.array,
  base, bias, bias_fut, cfg = get_spatial_bc_quantiles(lat_lon,
  base_dset,
  feature_name,
- bias_fp)
+ bias_fp,
+ threshold)
 
  if no_trend:
  mf = None

diff --git a/sup3r/preprocessing/data_handling/base.py b/sup3r/preprocessing/data_handling/base.py
@@ -1376,8 +1376,9 @@ def qdm_bc(self,
  self.lat_lon,
  reference_feature,
  feature,
- fp,
- relative)
+ bias_fp=fp,
+ threshold=threshold,
+ relative=relative)
  completed.append(feature)