Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kiva to v0.6.4 #9334

Merged
merged 14 commits into from
Mar 21, 2022
Merged

Update Kiva to v0.6.4 #9334

merged 14 commits into from
Mar 21, 2022

Conversation

nealkruis
Copy link
Member

@nealkruis nealkruis commented Mar 15, 2022

Pull request overview

Updates Kiva to v0.6.4 (from v0.6.1). This update includes:

Diffs are expected in any file that uses Kiva Foundations due to radiant boundary fixes.

Unit tests for these fixes are in the Kiva unit tests.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@nealkruis nealkruis added Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Mar 15, 2022
@nealkruis nealkruis added this to the EnergyPlus 22.1 milestone Mar 15, 2022
@shorowit shorowit linked an issue Mar 16, 2022 that may be closed by this pull request
3 tasks
@mitchute
Copy link
Collaborator

@nealkruis are you still targeting this release here? It would be nice to get this one in, and I think there's likely still a little time to resolve this if you're so inclined.

@nealkruis
Copy link
Member Author

Yes. I have a fix to push soon.

@nealkruis nealkruis changed the title Update Kiva to v0.6.3 Update Kiva to v0.6.4 Mar 19, 2022
@mitchute
Copy link
Collaborator

This looks ready. Merging.

@mitchute mitchute merged commit b59dc84 into NREL:develop Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze)
Projects
None yet
8 participants