Flag added to toggle daylight saving when used with Schedule:File #9251

prsh5175 · 2022-01-27T03:35:59Z

Pull request overview

Fixes Schedule:File option to ignore daylight savings time #8300

An optional field has been added to the IDD to indicate whether or not to shift the schedule forward an hour during daylight savings time. If the value is a "Yes", the schedule skips forward an hour in the CSV on the "spring forward" day and repeats an hour on the "fall back" day. If "No", the schedule is read and applied in standard time, without adjusting for daylight savings time. This indicator is defaulted to "Yes" if no input is provided.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

nmerket

Looks good so far. I think the next step is to do the input processing here.

nmerket · 2022-01-27T21:07:17Z

idd/Energy+.idd.in

+ A6 ; \field Daylight Savings Toggle
+ \note Toggles between daylight savings ON and Off (default)
+ \type choice
+ \key Yes
+ \key No
+ \default No


Just some minor suggested changes to the wording here.

Suggested change

A6 ; \field Daylight Savings Toggle

\note Toggles between daylight savings ON and Off (default)

\type choice

\key Yes

\key No

\default No

A6 ; \field Adjust Schedule for Daylight Savings

\note Turn ON to adjust the schedule for DST

\note Turn OFF to use the schedule directly (default)

\type choice

\key Yes

\key No

\default No

nmerket · 2022-01-27T21:08:08Z

src/EnergyPlus/ScheduleManager.hh

@@ -165,11 +165,12 @@ namespace ScheduleManager {
 Real64 CurrentValue; // For Reporting
 bool EMSActuatedOn; // indicates if EMS computed
 Real64 EMSValue;
+ bool UseDaylightSaving; // Toggles between daylight saving ON and OFF (default)


Seems light the right place to put this.

nmerket · 2022-01-27T21:09:52Z

src/EnergyPlus/ScheduleManager.hh


 // Default Constructor
 ScheduleData()
 : ScheduleTypePtr(0), WeekSchedulePointer(366, 0), Used(false), MaxMinSet(false), MaxValue(0.0), MinValue(0.0), CurrentValue(0.0),
- EMSActuatedOn(false), EMSValue(0.0)
+ EMSActuatedOn(false), EMSValue(0.0), UseDaylightSaving(false)


This is the same data structure used for all schedules in EnergyPlus. So, for every schedule except the Schedule:File this should be true. As such I think it makes sense to default it here to true.

… idd and ScheduleManager.hh

nmerket

@prsh5175 With the help of the E+ team, I found out how to add a file to the repo and add it to a test here. I've done the coding part but not the actual adding the file part. I'll leave that to you. I've also made notes (and pointed to them) for places you will want to add tests.

nmerket · 2022-02-07T19:52:32Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ // TODO: create this file with test data in it.
+ // This test will fail until you do that.
+ fs::path scheduleFile = configured_source_directory() / "tst/EnergyPlus/unit/Resources/schedule_file1.csv";


nmerket · 2022-02-07T19:52:54Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ // TODO: Add additional Schedule:File blocks above that test other possibilities to make sure they work right
+ // such as: 1.) Setting to "No"
+ // 2.) Leaving empty (should default to "No")
+ // 3.) Omitting the last field (should default to "No")
+ // Test that each option sets UseDaylightSaving correctly on the each schedule.


nmerket · 2022-02-07T19:54:54Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ // TODO: Call LookUpScheduleValue with DSTIndicator on and off and check that the correct hour of data is being returned.
+
+ state->dataEnvrn->DSTIndicator = 0; // Tells the simulation that we're NOT in daylight savings


Oh and I forgot to put it in the comments as well, but also test to make sure that it's pulling the correct values from the schedule when the simulation is not in daylight savings for both the cases of schedules with and without the "observe DST" switch we put in. So both would not jump forward an hour.

…n the current state - need to discuss more to mitigate current errors. Dummy schedule file csv added in the repo.

nmerket

It's coming along. See below for comments and guidance on next steps to get things working.

nmerket · 2022-02-08T16:10:09Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

@@ -831,6 +832,7 @@ TEST_F(EnergyPlusFixture, ScheduleFileColumnSeparator)
 " 8760, !- Number of Hours of Data",
 " Space, !- Column Separator",
 " No; !- Interpolate to Timestep"});
+ // Enter N4 and A6 fields here? (based on what is now defined in the IDD)


Yeah, that's something we'll need to do for backwards compatibility. Also with all the regression test files. And there's a version translator fortran thing you have to do as well. We'll get to that.

Is this still a to-do item?

nmerket · 2022-02-08T16:10:25Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ " Comma, !- Column Separator", // Changed the "space" separators to "comma"
+ " No, !- Interpolate to Timestep",
+ " 60, !- Minutes per item",
+ " Yes, !- Adjust Schedule for Daylight Savings",


Suggested change

" Yes, !- Adjust Schedule for Daylight Savings",

" Yes; !- Adjust Schedule for Daylight Savings",

Got it.. done

nmerket · 2022-02-08T16:10:40Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ " Comma, !- Column Separator",
+ " No, !- Interpolate to Timestep",
+ " 60, !- Minutes per item",
+ " No, !- Adjust Schedule for Daylight Savings",


Suggested change

" No, !- Adjust Schedule for Daylight Savings",

" No; !- Adjust Schedule for Daylight Savings",

nmerket · 2022-02-08T16:11:49Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ " No, !- Interpolate to Timestep",
+ " 60, !- Minutes per item",
+ " ; !- Adjust Schedule for Daylight Savings",
+ " ",


I'd also add one here that omits that last field. Something like:

"Schedule:File,", " Test4, !- Name", " , !- Schedule Type Limits Name", " " + scheduleFile.string() + ", !- File Name", " 1, !- Column Number", " 0, !- Rows to Skip at Top", " 8760, !- Number of Hours of Data", " Comma, !- Column Separator", " No, !- Interpolate to Timestep", " 60; !- Minutes per item",

nmerket · 2022-02-08T16:12:47Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ // TODO: Add additional Schedule:File blocks above that test other possibilities to make sure they work right
+ // such as: 1.) Setting to "No"
+ // 2.) Leaving empty (should default to "No")
+ // 3.) Omitting the last field (should default to "No")
+
+ // (PS: TODO items above -- Done)


Third one isn't done. See comment above.

Right. Test 4 is now added in the new version.

nmerket · 2022-02-08T16:21:13Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ EXPECT_EQ(state->dataGlobal->HourOfDay + state->dataEnvrn->DSTIndicator,
+ ScheduleManager::LookUpScheduleValue(*state, state->dataScheduleMgr->Schedule(sch1idx), state->dataGlobal->HourOfDay, state->dataGlobal->TimeStep));


What you're saying here is that you expect the hour of the day + the daylight savings indicator to be equal to the schedule value from the file. That's probably not going to work.

First, HourOfDay hasn't been set for this test. You'll need to do that. The best way to see what's going on is to put a debugger on this test and a breakpoint on this line and follow the values you're using. Step through LookUpScheduleValue and make sure variables from the state that it is using are set in your test.

Once you get that sorted out and it's pulling the value out of the schedule file. You'll want to compare the value of the schedule at a given day and hour not the hour itself. The test schedule file you added above is very realistic, but maybe not the best for testing. It may be useful to have the schedule with like a value of 1 for the hour before the one you want and 2 for the hour you want, or something like that. The rest can be filled with whatever. That way testing for values becomes pretty straightforward.

I see. That make a lot more sense now. OK, trying this part now. Thanks Noel.

idd/Energy+.idd.in

mjwitte · 2022-02-08T19:28:24Z

idd/Energy+.idd.in

+ \note Turn ON to adjust the schedule for DST
+ \note Turn OFF to use the schedule directly (default)


Since the key choices are Yes/No, the notes should use those words instead of Turn On/Off.

Good point.

Noted, thanks. Changing the notes as follows in the new version: "
\note "Yes" means include Daylight Savings Time to the schedule
\note "No" means do not include Daylight Savings Time in the schedule, instead, use the schedule directly from the Schedule:File csv (default) "

nmerket · 2022-02-09T19:49:16Z

Decision from EnergyPlus technicalities call:

Change the default to "YES"
No transition code needed.
Alter warning so it will not appear if the user selects "NO".

…dule:File csv updated with first 24 hours of value 1 and rest 0.

mjwitte · 2022-02-14T15:30:13Z

@prsh5175 @nmerket In case you didn't notice, there are format and test failures that need to be addressed. When this is ready for final review, please change this from Draft to ready for review.

nmerket · 2022-02-15T00:22:36Z

@prsh5175 I think I got the unit test and the default functionality working right. Let's see what comes out of the CI runs overnight. If that comes back clean, I think all we have left is the Input/Output Reference.

…ghtSavingsToggle

… Group - Schedules > Schedule:File > Field: Adjust Schedule for Daylight Savings

nmerket

@prsh5175 See my suggested edits to the docs below. I think we'll also want to do something with this warning as well. I'm on the fence of whether to remove it entirely or move it somewhere and only call it when we think someone is doing something dumb.

@mjwitte @bonnema

doc/input-output-reference/src/overview/group-schedules.tex

nmerket · 2022-02-15T21:42:02Z

Decision: remove the warning since there's an explicit switch for it now. Bonus: should make things faster since it was being called a lot.

Co-authored-by: Noel Merket <[email protected]>

prsh5175 · 2022-02-15T23:18:13Z

doc/input-output-reference/src/overview/group-schedules.tex

+\paragraph{Field: Adjust Schedule for Daylight Savings}\label{adjust-schedule-for-daylight-savings-1}
+
+This field indicates whether or not to shift the schedule forward an hour during daylight savings time. If "Yes" the schedule skips forward an hour in the CSV on the "spring forward" day and repeats an hour on the "fall back" day. If "No", the schedule is read and applied in standard time, without adjusting for daylight savings time. This indicator is defaulted to "Yes" if no input is provided. 
+
+Here is an IDF example:
+
+\begin{lstlisting}
+ Schedule:File,
+ TestName, !- Name
+ Any Number, !- Schedule Type Limits Name
+ schedulefile.csv, !- File Name
+ 2, !- Column Number
+ 1, !- Rows to Skip at Top
+ 8760, !- Number of Hours of Data
+ Comma, !- Column Separator
+ No, !- Interpolate to Timestep
+ 60, !- Minutes per Item
+ No; !- Flag to Adjust Schedule for Daylight Savings
+\end{lstlisting}
+


Added a paragraph in the documentation detailing the use of the optional flag to choose whether or not to shift the schedule values when daylight savings time is being included with a "Yes" value for the indicator.

prsh5175 · 2022-02-15T23:19:29Z

idd/Energy+.idd.in

+ \note "Yes" means include Daylight Savings Time to the schedule
+ \note "No" means do not include Daylight Savings Time in the schedule, instead, use the schedule directly from the Schedule:File csv (default)
+ \type choice
+ \key Yes
+ \key No
+ \default Yes


Description of "Yes" and "No" options.

prsh5175 · 2022-02-15T23:21:59Z

src/EnergyPlus/ScheduleManager.cc

+ if (lAlphaBlanks(6)) Alphas(6) = "YES";
+ if ((Alphas(6)) == "YES") {
+ state.dataScheduleMgr->Schedule(SchNum).UseDaylightSaving = true;
+ } else if ((Alphas(6)) == "NO") {
+ state.dataScheduleMgr->Schedule(SchNum).UseDaylightSaving = false;
+ }
+


If Alphas(6) field is a "Yes" or a blank, assign a "true" value to the UseDaylightSaving boolean, otherwise assign a "false" value. This boolean is then used in an if statement to decide whether or not to shift the schedule by one hour forward.

prsh5175 · 2022-02-15T23:24:52Z

src/EnergyPlus/ScheduleManager.cc

@@ -2776,7 +2765,13 @@ namespace ScheduleManager {
 // so, current date, but maybe TimeStep added

 // Hourly Value
- int thisHour = ThisHour + state.dataEnvrn->DSTIndicator;
+ int thisHour;


Initialized "thisHour" outside the scope of the if statement. Its value is changed based on whether the UseDaylightSaving boolean has a "true" or a "false" value.

prsh5175 · 2022-02-15T23:26:58Z

src/EnergyPlus/ScheduleManager.cc

+ if (state.dataScheduleMgr->Schedule(ScheduleIndex).UseDaylightSaving) {
+ thisHour = ThisHour + state.dataEnvrn->DSTIndicator;
+ } else {
+ thisHour = ThisHour;
+ }
+


If the "UseDaylightSaving" boolean has a "true" value, the "thisHour" variable adds the DSTIndicator (value of 1 hour) to the "ThisHour" variable (note the capital vs small lettering in the variable names), otherwise, the hour value is unchanged (i.e., daylight savings time effect is not accounted for).

I think Yoda taught me that booleans are simply 0 or 1, so I think this entire if/else could be reduced to
int const thisHour = ThisHour + state.dataEnvrn->DSTIndicator * state.dataScheduleMgr->Schedule(ScheduleIndex).UseDaylightSaving;
@Myoldmopar would this be the best solution?

prsh5175 · 2022-02-15T23:32:57Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ " Comma, !- Column Separator",
+ " No, !- Interpolate to Timestep",
+ " 60, !- Minutes per item",
+ " ; !- Adjust Schedule for Daylight Savings",


Note: Putting nothing here in the IDF for the flag (neither a "Yes" nor a "No").

prsh5175 · 2022-02-15T23:33:51Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ " Comma, !- Column Separator",
+ " No, !- Interpolate to Timestep",
+ " 60; !- Minutes per item",
+ " ",


Omitting the field all together, per the comment from @nmerket

prsh5175 · 2022-02-15T23:35:13Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ state->dataGlobal->NumOfTimeStepInHour = 1;
+ state->dataGlobal->MinutesPerTimeStep = 60;
+ state->dataGlobal->TimeStep = 1; // Checking to see if omitting this is OK here
+ state->dataEnvrn->DayOfWeek = 1; // Sunday
+ state->dataEnvrn->DayOfWeekTomorrow = 2; // Monday
+ state->dataEnvrn->DayOfYear_Schedule = 1;
+ state->dataGlobal->HourOfDay = 24;


Initiation of these variables within the unit testing scope.

prsh5175 · 2022-02-15T23:41:28Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ state->dataEnvrn->DayOfYear_Schedule = 1;
+ state->dataGlobal->HourOfDay = 24;
+
+ // Test 1 condition


Testing four different conditions each starting with a comment line that says "// Test X condition "...

prsh5175 · 2022-02-15T23:48:30Z

tst/EnergyPlus/unit/ScheduleManager.unit.cc

+ EXPECT_TRUE(sch1.UseDaylightSaving); // Checks that the member variable got set correctly.
+
+ state->dataEnvrn->DSTIndicator = 1; // Tells the simulation that we're currently observing daylight savings
+ EXPECT_DOUBLE_EQ(ScheduleManager::LookUpScheduleValue(*state, sch1idx, state->dataGlobal->HourOfDay, state->dataGlobal->TimeStep), 0.0);


Comparing the value from the CSV file that is looked up against the expected value of 0 for the 24th hour of the day.

prsh5175 · 2022-02-16T00:02:09Z

The regression test diffs are OK because there are new field(s) with defaults, and new field(s) which are being defaulted (because the existing files don't have the new field present, thus they get defaulted).

prsh5175 · 2022-02-16T00:04:28Z

The following warning has been removed from ScheduleManager.cc since the indicator value is actively being assigned in the IDF now, and removing this warning will also speed up the run since there are fewer checks needed:

if (!state.dataScheduleMgr->ScheduleDSTSFileWarningIssued) {
if (state.dataEnvrn->DSTIndicator == 1) {
if (state.dataScheduleMgr->Schedule(ScheduleIndex).SchType == SchedType::ScheduleInput_file) {
ShowWarningError(state,
"GetCurrentScheduleValue: Schedule="" + state.dataScheduleMgr->Schedule(ScheduleIndex).Name +
"" is a Schedule:File");
ShowContinueError(state, "...Use of Schedule:File when DaylightSavingTime is in effect is not recommended.");
ShowContinueError(state, "...1) Remove RunperiodControl:DaylightSavingTime object or remove DST period from Weather File.");
ShowContinueError(state, "...2) Configure other schedules and Schedule:File to account for occupant behavior during DST.");
ShowContinueError(state, "... If you have already done this, you can ignore this message.");
ShowContinueError(state,
"...When active, DaylightSavingTime will shift all scheduled items by one hour, retaining the same day type as "
"the original.");
state.dataScheduleMgr->ScheduleDSTSFileWarningIssued = true;
}
}
}

mjwitte · 2022-02-16T01:24:05Z

doc/input-output-reference/src/overview/group-schedules.tex

@@ -542,6 +542,26 @@ \subsubsection{Inputs}\label{inputs-9-019}
 60; !- Minutes per Item
 \end{lstlisting}

+\paragraph{Field: Adjust Schedule for Daylight Savings}\label{adjust-schedule-for-daylight-savings-1}
+
+This field indicates whether or not to shift the schedule forward an hour during daylight savings time. If "Yes" the schedule skips forward an hour in the CSV on the "spring forward" day and repeats an hour on the "fall back" day. If "No", the schedule is read and applied in standard time, without adjusting for daylight savings time. This indicator is defaulted to "Yes" if no input is provided. 


Please fix the quote marks. Use ``text''.

mjwitte · 2022-02-16T01:25:24Z

idd/Energy+.idd.in

+ \note "Yes" means include Daylight Savings Time to the schedule
+ \note "No" means do not include Daylight Savings Time in the schedule, instead, use the schedule directly from the Schedule:File csv (default)


move "(default)" to the first note.

Default moved to the first note.

mjwitte · 2022-02-16T01:32:20Z

src/EnergyPlus/ScheduleManager.cc

+ if (lAlphaBlanks(6)) Alphas(6) = "YES";
+ if ((Alphas(6)) == "YES") {
+ state.dataScheduleMgr->Schedule(SchNum).UseDaylightSaving = true;


Nit picking. But the first 2 lines here are not necessary. Start with line 1654, then reset it if Alphas(6) = No.

Addressed per comment.

mjwitte · 2022-02-16T01:35:37Z

src/EnergyPlus/ScheduleManager.cc

+ if (state.dataScheduleMgr->Schedule(ScheduleIndex).UseDaylightSaving) {
+ thisHour = ThisHour + state.dataEnvrn->DSTIndicator;
+ } else {
+ thisHour = ThisHour;
+ }
+


I think Yoda taught me that booleans are simply 0 or 1, so I think this entire if/else could be reduced to
int const thisHour = ThisHour + state.dataEnvrn->DSTIndicator * state.dataScheduleMgr->Schedule(ScheduleIndex).UseDaylightSaving;
@Myoldmopar would this be the best solution?

bonnema · 2022-02-16T04:00:08Z

doc/input-output-reference/src/overview/group-schedules.tex

+ Comma, !- Column Separator
+ No, !- Interpolate to Timestep
+ 60, !- Minutes per Item
+ No; !- Flag to Adjust Schedule for Daylight Savings


Remove "Flag to " from field comment to match IDD.

"Flag to " removed.

bonnema · 2022-02-16T04:02:10Z

doc/input-output-reference/src/overview/group-schedules.tex

+\paragraph{Field: Adjust Schedule for Daylight Savings}\label{adjust-schedule-for-daylight-savings-1}
+
+This field indicates whether or not to shift the schedule forward an hour during daylight savings time. If "Yes" the schedule skips forward an hour in the CSV on the "spring forward" day and repeats an hour on the "fall back" day. If "No", the schedule is read and applied in standard time, without adjusting for daylight savings time. This indicator is defaulted to "Yes" if no input is provided. 
+


Maybe add a reference to the DST object? Via Latex, not the web (hopefully that was obvious, just easier for me to find the web version 😀)

DST object referenced in LaTeX.

bonnema · 2022-02-16T04:07:04Z

@prsh5175 See my suggested edits to the docs below. I think we'll also want to do something with this warning as well. I'm on the fence of whether to remove it entirely or move it somewhere and only call it when we think someone is doing something dumb.

@mjwitte @bonnema

I think that if the flag is set to 'yes' this warning can be skipped. This means the user wants it this way. If it is set to 'no' (the default, especially if the optional field is not there) then the warning continues like it always has. Basically, a 'yes' gets rid of the warning?

nmerket · 2022-02-16T13:14:35Z

@prsh5175 See my suggested edits to the docs below. I think we'll also want to do something with this warning as well. I'm on the fence of whether to remove it entirely or move it somewhere and only call it when we think someone is doing something dumb.
@mjwitte @bonnema

I think that if the flag is set to 'yes' this warning can be skipped. This means the user wants it this way. If it is set to 'no' (the default, especially if the optional field is not there) then the warning continues like it always has. Basically, a 'yes' gets rid of the warning?

The default and previous behavior is "Yes". That means we're currently throwing the warning in the "Yes" case. We don't want to throw this warning if the user selects "No". Are you suggesting that we differentiate between whether the user allows this field to be defaulted to "Yes" or whether they explicitly enter a "Yes" on the object and then only throw the warning in the former case? That seems like a hassle to me. I guess I figure that since there's a documented input for the behavior now, we just don't need this anymore.

bonnema · 2022-02-16T13:32:30Z

My bad. I got the default mixed up. Sorry for the confusion. I think we're saying the same thing. To reiterate: If 'yes' (previous and default) keep the warning. Basically no change. If 'no' (new option) then warning is skipped.

…le_DaylightSavingsToggle

mjwitte

So, decided to test this using 5ZoneTDV. Extended the Schedule:File object with blank fields and then added the DST flag. It crashed. Why? Because Minutes per Item didn't have a default and came in as zero.
Did some IDD cleanup and tried again. Now it runs. Compared with DST = Yes and No. Identical results. Hmmmm. Duh, 5ZoneTDV doesn't have daylight savings. Well, ok, so these should be identical.
Added DST and compared again with schedule DST = Yes and No. Voila! Different source energy.
Pushing up idd changes and some changes to 5ZoneTDV to extend the object with all fields and No for DST ('cause that's probably correct for the TDV schedules). And added output variables for source energy 'cause that's of most interest. This shouldn't trigger any CI diffs (yah, sure it won't).

Will merge in the morning assuming CI comes back clean.
And this showed a 0.36% speedup. Whoop whoop!!

bonnema · 2022-03-15T21:15:25Z

😆 https://www.reuters.com/world/us/us-senate-approves-bill-that-would-make-daylight-savings-time-permanent-2023-2022-03-15/

nmerket · 2022-03-15T21:51:01Z

@bonnema I'm all for it personally. This spring forward thing is 🤬 . I always come back to this segment from John Oliver

https://www.youtube.com/watch?v=br0NW9ufUUw

mjwitte · 2022-03-15T22:25:53Z

So, will EnergyPlus accept a DST period from Jan 1 - Dec 31? I suppose it should. Then the entire schedule should shift, or not, or ? And that will bring into question the timing of weather data if we're always on DST will it be recorded with ST timestamps? Head is starting to spin...

prsh5175 · 2022-03-15T22:48:03Z

😄 It would make everyone's life so much easier if the permanent situation was ST (instead of DST)..like the rest of the world! (and same for SI system...and maybe a bunch of other things but for now let's leave it at SI system).

…

On Tue, Mar 15, 2022 at 4:26 PM Michael J. Witte ***@***.***> wrote: So, will EnergyPlus accept a DST period from Jan 1 - Dec 31? I suppose it should. Then the entire schedule should shift, or not, or ? And that will bring into question the timing of weather data if we're always on DST will it be recorded with ST timestamps? Head is starting to spin... — Reply to this email directly, view it on GitHub <#9251 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKYK2HSJ3B3AMYENUCVKRS3VAEE7ZANCNFSM5M4YJB4Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

nmerket · 2022-03-15T23:01:05Z

That's a good question @mjwitte. Seems like it should be able to, but I think we'd need to try it to make sure.

Ultimately, it's just the same as being on standard time with a different offset from UTC. Seems like this could be easily achieved by modifying the epw file to shift everything by an hour. I imagine that TMY3 would be updated to reflect that (TMY4?).

nmerket · 2022-03-15T23:04:32Z

But let's wait on all that until congress actually passes something. I'll believe this when I see it.

Flag added to toggle daylight saving when used with Schedule:File

3847212

nmerket reviewed Jan 27, 2022

View reviewed changes

prsh5175 and others added 3 commits January 28, 2022 14:48

Data processing steps added to utilize changes previously made in the…

936316e

… idd and ScheduleManager.hh

Unit test progress

20a84fb

helping with some tests

3304fff

nmerket reviewed Feb 7, 2022

View reviewed changes

Changes added per the comments from @nmerket. Contains build errors i…

fb0a324

…n the current state - need to discuss more to mitigate current errors. Dummy schedule file csv added in the repo.

nmerket reviewed Feb 8, 2022

View reviewed changes

mjwitte added IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) NewFeature Includes code to add a new feature to EnergyPlus labels Feb 8, 2022

mjwitte added this to the EnergyPlus 22.1 IOFreeze milestone Feb 8, 2022

mjwitte reviewed Feb 8, 2022

View reviewed changes

idd/Energy+.idd.in Show resolved Hide resolved

mjwitte reviewed Feb 8, 2022

View reviewed changes

Unit tests updated with previous comments and discussions; dummy Sche…

4361ae4

…dule:File csv updated with first 24 hours of value 1 and rest 0.

nmerket added 4 commits February 14, 2022 10:09

running clang-format

07a4f38

fixing unit tests and default

6137145

clean up

bc4da13

clang format again

20071f8

nmerket and others added 2 commits February 15, 2022 09:41

Merge remote-tracking branch 'origin/develop' into ScheduleFile_Dayli…

947b222

…ghtSavingsToggle

Paragraph added in documentation (Input/Output Reference) > Overview>…

fe834ec

… Group - Schedules > Schedule:File > Field: Adjust Schedule for Daylight Savings

nmerket reviewed Feb 15, 2022

View reviewed changes

doc/input-output-reference/src/overview/group-schedules.tex Outdated Show resolved Hide resolved

nmerket added 2 commits February 15, 2022 14:37

removing warning about DST and Schedule:File

492e111

clang-format-ed

2cdf140

prsh5175 and others added 2 commits February 15, 2022 14:49

Update doc/input-output-reference/src/overview/group-schedules.tex

e0576e6

Co-authored-by: Noel Merket <[email protected]>

Fixed minor typo (quotes).

7cfe15e

prsh5175 commented Feb 15, 2022

View reviewed changes

prsh5175 marked this pull request as ready for review February 15, 2022 23:59

mjwitte reviewed Feb 16, 2022

View reviewed changes

bonnema reviewed Feb 16, 2022

View reviewed changes

prsh5175 and others added 5 commits February 16, 2022 11:55

Review comments addressed.

446dafe

DST reference updated.

e9ad47d

Clang compile re-run

a45cf00

Merge remote-tracking branch 'remotes/origin/develop' into ScheduleFi…

1c50321

…le_DaylightSavingsToggle

Schedule:File dst cleanup

af6f344

mjwitte approved these changes Feb 18, 2022

View reviewed changes

mjwitte merged commit e3205a4 into develop Feb 18, 2022

mjwitte deleted the ScheduleFile_DaylightSavingsToggle branch February 18, 2022 14:30

		// TODO: Call LookUpScheduleValue with DSTIndicator on and off and check that the correct hour of data is being returned.

		state->dataEnvrn->DSTIndicator = 0; // Tells the simulation that we're NOT in daylight savings

	" Yes, !- Adjust Schedule for Daylight Savings",
	" Yes; !- Adjust Schedule for Daylight Savings",

	" No, !- Adjust Schedule for Daylight Savings",
	" No; !- Adjust Schedule for Daylight Savings",

		EXPECT_EQ(state->dataGlobal->HourOfDay + state->dataEnvrn->DSTIndicator,
		ScheduleManager::LookUpScheduleValue(*state, state->dataScheduleMgr->Schedule(sch1idx), state->dataGlobal->HourOfDay, state->dataGlobal->TimeStep));

		\note Turn ON to adjust the schedule for DST
		\note Turn OFF to use the schedule directly (default)

		\note "Yes" means include Daylight Savings Time to the schedule
		\note "No" means do not include Daylight Savings Time in the schedule, instead, use the schedule directly from the Schedule:File csv (default)

		\paragraph{Field: Adjust Schedule for Daylight Savings}\label{adjust-schedule-for-daylight-savings-1}

		This field indicates whether or not to shift the schedule forward an hour during daylight savings time. If "Yes" the schedule skips forward an hour in the CSV on the "spring forward" day and repeats an hour on the "fall back" day. If "No", the schedule is read and applied in standard time, without adjusting for daylight savings time. This indicator is defaulted to "Yes" if no input is provided.

Flag added to toggle daylight saving when used with Schedule:File #9251

Flag added to toggle daylight saving when used with Schedule:File #9251

Conversation

prsh5175 commented Jan 27, 2022 • edited by mjwitte Loading

Pull request overview

Pull Request Author

Reviewer

nmerket left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmerket left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmerket left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmerket commented Feb 9, 2022

mjwitte commented Feb 14, 2022

nmerket commented Feb 15, 2022

nmerket left a comment

Choose a reason for hiding this comment

nmerket commented Feb 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsh5175 commented Feb 16, 2022

prsh5175 commented Feb 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bonnema Feb 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bonnema commented Feb 16, 2022

nmerket commented Feb 16, 2022

bonnema commented Feb 16, 2022 • edited Loading

mjwitte left a comment

Choose a reason for hiding this comment

bonnema commented Mar 15, 2022

nmerket commented Mar 15, 2022

mjwitte commented Mar 15, 2022

prsh5175 commented Mar 15, 2022 via email

nmerket commented Mar 15, 2022

nmerket commented Mar 15, 2022

prsh5175 commented Jan 27, 2022 •

edited by mjwitte

Loading

prsh5175 commented Feb 16, 2022 •

edited

Loading

bonnema Feb 16, 2022 •

edited

Loading

bonnema commented Feb 16, 2022 •

edited

Loading