Enhancing Multi-speed Coil Speed Level Control Actuators #9185

xuanluo113 · 2021-11-12T04:34:49Z

Pull request overview

Previously in the 9.6.0 release, we added the EMS actuators to control the speed level of the cooling and heating multispeed coils, namely Coil:Cooling:DX:MultiSpeed and Coil:Heating:DX:Multispeed. As an enhancement, we propose to extend the EMS functionality to a more general coil type in EnergyPlus, Coil:Cooling:DX, which will replace the single speed, two speed, variable speed, multi-speed, and multi-stage coils going forward.

Result of the testfiles/EMSLoadBasedMultiSpeedDXCoilOverrideControl.idf

Result of the testfiles/EMSSetpointBasedMultiSpeedDXCoilOverrideControl.idf

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

mjwitte · 2021-11-18T19:23:05Z

@xuanluo113 This is straightforward enough. If I'm following correctly, since the actuator is applied to the unitary system, there is no change in inputs for this, just doc and code changes to extend this to work with Coil:Cooling:DX. When updating the documentation, some reformatting would be helpful (the Unitary Equipment actuator section is a bit hard to navigate).

…l-speed-actuator

xuanluo113 · 2021-11-25T06:25:51Z

The branch is ready for review with a new unit test and three test files. Results are illustrated in the overview.

xuanluo113 · 2021-11-29T21:14:26Z

@mjwitte @Myoldmopar Mike and Edwin, this branch is ready for review, and I wonder if you could take a look. As for the documentation, I'm not sure what is a better place to add the EMS description other than the Unitary Equipment, since the actuators are based on unitary systems.

…-actuator

mjwitte

Regarding the documentation, it's fine to include it with the unitarysystem actuators, but that section could use some subheadings or something to make it more readable.

mjwitte · 2021-11-30T13:46:08Z

src/EnergyPlus/UnitarySystem.cc

+                        this->m_SpeedNum = this->m_NumOfSpeedCooling;
+                        CycRatio = this->m_CoolingCycRatio = 1.0;
+                        PartLoadFrac = SpeedRatio = this->m_CoolingSpeedRatio = 1.0;
+                        this->m_CoilSpeedErrIdx++;


This index should not be incremented here. This is an index to this particular recurring error message. If it's zero ShowRecurringWarningErrorAtEnd will set it to the next available index. There should also be a regular warning message issued the first time this occurs (i.e. when m_CoilSpeedErrIdx=0) . See UnitarySystem.cc lines 9347ff for an example of how to use ShowRecurringWarningErrorAtEnd.

mjwitte · 2021-11-30T13:53:35Z

src/EnergyPlus/UnitarySystem.cc

+                    } else if (this->m_CoolingSpeedNum == 1) {
+                        SpeedRatio = this->m_CoolingSpeedRatio = 0.0;
+                        CycRatio = this->m_CoolingCycRatio = this->m_EMSOverrideCoilSpeedNumValue - floor(this->m_EMSOverrideCoilSpeedNumValue);
+                        if (useMaxedSpeed || this->m_CoolingCycRatio == 0) {


Not sure this should be an else if. Looks like useMaxedSpeed will always be false here.

mjwitte · 2021-11-30T14:04:53Z

src/EnergyPlus/UnitarySystem.cc

+                    } else {
+                        CycRatio = this->m_CoolingCycRatio = 1.0;
+                        SpeedRatio = this->m_CoolingSpeedRatio = this->m_EMSOverrideCoilSpeedNumValue - floor(this->m_EMSOverrideCoilSpeedNumValue);


What if m_EMSOverrideCoilSpeedNumValue is <= 0?

…l-speed-actuator

xuanluo113 · 2021-12-02T00:41:03Z

@mjwitte Hi Mike. I've fixed the recurring warning issues, and added some subsubsection headings in the doc.

into coil-speed-actuator

mjwitte

This is better, but there is a failed unit test now.

Thanks for adding the subheadings in the unitary equipment EMS actuators section. Please add one more "Unitary System Sizing" before the paragraph starting with "Actuators are available for overriding the autosize values".

mjwitte · 2021-12-02T23:10:17Z

src/EnergyPlus/UnitarySystem.cc

+                            ShowContinueError(state,
+                                              "  Exceeding maximum coil speed level. Speed level is set to the maximum coil speed level allowed.");
+                        }
+                        ShowRecurringWarningErrorAtEnd(


This is better. I was going to comment that the two error messages here will conflict once the m_CoilSpeedErrIdx is set. But now I see that ShowRecurringWarningErrorAtEnd ignores the incoming index and searches for a matching error string. A test file which sets the coil speed to values higher than max peed, and to negative values, does produce both recurring error messages. So, this is fine as-is.

mjwitte · 2021-12-02T23:10:47Z

src/EnergyPlus/UnitarySystem.cc

@@ -12281,6 +12292,35 @@ namespace UnitarySystems {
                        } else if (this->m_DehumidificationMode == 1) {
                            OperationMode = DataHVACGlobals::coilEnhancedMode;
                        }
+
+                        //                        if (this->m_EMSOverrideCoilSpeedNumOn) {


There's a block of commented code here that needs to be removed.

mjwitte · 2021-12-02T23:12:35Z

testfiles/CMakeLists.txt

@@ -249,10 +249,12 @@ add_simulation_test(IDF_FILE EMSCustomOutputVariable.idf EPW_FILE USA_IL_Chicago
 add_simulation_test(IDF_FILE EMSCustomSchedule.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE EMSDemandManager_LargeOffice.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
 add_simulation_test(IDF_FILE EMSDiscreteAirSystemSizes.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
+add_simulation_test(IDF_FILE EMSLoadBasedMultiSpeedDXCoilOverrideControl.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)


This new test file has some warnings:

************* ** Warning ** SimHVAC: Exceeding Maximum iterations for all HVAC loops, during JAN14 continues ************* ** ~~~ ** This error occurred 44 total times; ************* ** ~~~ ** during Warmup 0 times; ************* ** ~~~ ** during Sizing 0 times. ************* ************* ** Warning ** Wrong coil speed EMS override value, for unit="SYS 1 FURNACE DX COOL HEATING COIL". Exceeding maximum coil speed level. Speed level is set to the maximum coil speed level allowed. ************* ** ~~~ ** This error occurred 63 total times; ************* ** ~~~ ** during Warmup 54 times; ************* ** ~~~ ** during Sizing 0 times. ************* ** ~~~ ** Max=1. Min=1.

into coil-speed-actuator

mjwitte

@xuanluo113
Docs are good.
Unit tests pass.
Output variable warnings are gone (I just pushed up that change for the other idf).
Still troubled by these warnings in EMSLoadBasedMultiSpeedDXCoilOverrideControl:

   *************  ** Warning ** SimHVAC: Exceeding Maximum iterations for all HVAC loops, during JAN14 continues
   *************  **   ~~~   **   This error occurred 44 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************
   *************  ** Warning ** Wrong coil speed EMS override value, for unit="SYS 1 FURNACE DX COOL HEATING COIL". Exceeding maximum coil speed level. Speed level is set to the maximum coil speed level allowed.
   *************  **   ~~~   **   This error occurred 63 total times;
   *************  **   ~~~   **   during Warmup 54 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=1.  Min=1.
   *************
   *************  ** Warning ** SimHVAC: Exceeding Maximum iterations for all HVAC loops, during JULY7 continues
   *************  **   ~~~   **   This error occurred 4 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.

If there's not an obvious fix for these, please post a followup issue to investigate further.

mjwitte · 2021-12-03T21:02:42Z

Merging this. Will post a followup issue about the warnings in EMSLoadBasedMultiSpeedDXCoilOverrideControl.

Enhancing Multi-speed Coil Speed Level Control Actuators

ems actuators

c1e7966

xuanluo113 added the NewFeature Includes code to add a new feature to EnergyPlus label Nov 12, 2021

xuanluo113 added this to the EnergyPlus 2022.1 milestone Nov 12, 2021

xuanluo113 self-assigned this Nov 12, 2021

xuanluo113 requested review from mjwitte and Myoldmopar November 12, 2021 17:47

xuanluo113 added 4 commits November 18, 2021 14:42

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into coi…

f6a6b17

…l-speed-actuator

ems code and test

34d0f81

test files

af675fc

unit test

c726530

Merge remote-tracking branch 'remotes/origin/develop' into coil-speed…

0597415

…-actuator

mjwitte reviewed Nov 30, 2021

View reviewed changes

xuanluo113 added 2 commits December 1, 2021 16:39

fix recurring warning

693d34f

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into coi…

2f06ed4

…l-speed-actuator

Merge branch 'coil-speed-actuator' of https://github.com/NREL/EnergyPlus

9bf7e3c

into coil-speed-actuator

mjwitte reviewed Dec 2, 2021

View reviewed changes

xuanluo113 and others added 3 commits December 2, 2021 20:04

address comments

d9ac5ac

Merge branch 'coil-speed-actuator' of https://github.com/NREL/EnergyPlus

af79208

into coil-speed-actuator

Output variable cleanup

6717133

mjwitte approved these changes Dec 3, 2021

View reviewed changes

mjwitte merged commit e6e681d into develop Dec 3, 2021

mjwitte deleted the coil-speed-actuator branch December 3, 2021 21:02

mjwitte mentioned this pull request Dec 3, 2021

EMSLoadBasedMultiSpeedDXCoilOverrideControl has max iteration and bad speed value warnings #9203

Open

3 tasks

yujiex pushed a commit that referenced this pull request Jan 27, 2022

Merge pull request #9185 from NREL/coil-speed-actuator

0b2cf6b

Enhancing Multi-speed Coil Speed Level Control Actuators

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancing Multi-speed Coil Speed Level Control Actuators #9185

Enhancing Multi-speed Coil Speed Level Control Actuators #9185

xuanluo113 commented Nov 12, 2021 •

edited

Loading

mjwitte commented Nov 18, 2021

xuanluo113 commented Nov 25, 2021

xuanluo113 commented Nov 29, 2021

mjwitte left a comment

mjwitte Nov 30, 2021

mjwitte Nov 30, 2021

mjwitte Nov 30, 2021

xuanluo113 commented Dec 2, 2021

mjwitte left a comment

mjwitte Dec 2, 2021

mjwitte Dec 2, 2021

mjwitte Dec 2, 2021

mjwitte left a comment

mjwitte commented Dec 3, 2021

Enhancing Multi-speed Coil Speed Level Control Actuators #9185

Enhancing Multi-speed Coil Speed Level Control Actuators #9185

Conversation

xuanluo113 commented Nov 12, 2021 • edited Loading

Pull request overview

Pull Request Author

Reviewer

mjwitte commented Nov 18, 2021

xuanluo113 commented Nov 25, 2021

xuanluo113 commented Nov 29, 2021

mjwitte left a comment

Choose a reason for hiding this comment

mjwitte Nov 30, 2021

Choose a reason for hiding this comment

mjwitte Nov 30, 2021

Choose a reason for hiding this comment

mjwitte Nov 30, 2021

Choose a reason for hiding this comment

xuanluo113 commented Dec 2, 2021

mjwitte left a comment

Choose a reason for hiding this comment

mjwitte Dec 2, 2021

Choose a reason for hiding this comment

mjwitte Dec 2, 2021

Choose a reason for hiding this comment

mjwitte Dec 2, 2021

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

mjwitte commented Dec 3, 2021

xuanluo113 commented Nov 12, 2021 •

edited

Loading