Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a link in the readme #9115

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

DaveInCaz
Copy link
Contributor

Pull request overview

This is just a broken link in the readme file.

Pull Request Author

n/a

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmythms
Copy link
Contributor

jmythms commented Oct 12, 2021

Good catch! I'd suggest setting the PR label as Defect or Documentation.

@mjwitte
Copy link
Contributor

mjwitte commented Oct 12, 2021

Or maybe we need to change the wiki page name back to what it was?

@Myoldmopar Myoldmopar added the Defect Includes code to repair a defect in EnergyPlus label Oct 12, 2021
@Myoldmopar
Copy link
Member

Good catch! I'd suggest setting the PR label as Defect or Documentation.

@jmythms just a heads up that I don't think external contributors can modify the labels, only authorized users. I made it defect.

@DaveInCaz I can't recall, have you submitted a contributor agreement? Even for a small typo like this we still need to make sure we are covered when taking any contribution. I don't see it in my current documents, but I may be looking under the wrong name. If you haven't, go ahead and check one out here and get it submitted and we'll accept this directly.

Thanks!

@DaveInCaz
Copy link
Contributor Author

@Myoldmopar I have just done so. Thanks for pointing that out.

@Myoldmopar
Copy link
Member

Thanks @DaveInCaz , I received it and filed it. You are now able to contribute changes, and I will accept this typo fix to kick that off.

@Myoldmopar Myoldmopar merged commit b448a82 into NREL:develop Nov 1, 2021
yujiex pushed a commit that referenced this pull request Jan 27, 2022
Corrected a link in the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants