Add warnings/errors for unreasonable DHW temperatures for WaterUse:Equipment #8808

matthew-larson · 2021-06-08T19:52:56Z

Pull request overview

Fixes Feature Request: Generate Warning when a WaterUse:Equipment object has a target temperature is below water temperature #7133 and No error/warning if DHW hot water temp is less than the cold water temp #8806
This pull request adds warnings for unreasonable DHW temperatures for the target temperature, hot water temperature, and cold water temperature. A general warning will be included if it only occurs once, but a recurring warning will be generated if it occurs multiple times. This will help prevent unreasonable water temperatures by warning the user if the hot water temperature is below the cold water temperature, and if the target temperature is below the cold water temperature or above the hot water temperature, making the target temperature unachievable and the energy consumption inaccurate.
Created a new unit test file for WaterUse.unit.cc that has a unit test that checks these three warnings.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
If any diffs are expected, author must demonstrate they are justified using plots and descriptions
If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
If branch is behind develop, merge develop and build locally to check for side effects of the merge
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
CI status: all green or justified
Check that performance is not impacted (CI Linux results include performance check)
Run Unit Test(s) locally

…water temperature.

…perature.

…ture.

…-waterusetemp-error

matthew-larson · 2021-06-09T14:19:49Z

All diffs are due to situations where the target water temperature is unachievable due to the hot water temperature, or the hot water temperature is below the cold water temperature. Not sure if these should be investigated in the models to eliminate these warnings.

Nigusse · 2021-07-16T13:42:49Z

src/EnergyPlus/WaterUse.cc

+                        this->HWTempErrIndex,
+                        this->HotTemp,
+                        this->HotTemp);
+                }


Catches when Cold water temp is > available Hot water temp and throws one time and recurring warning error message.

Nigusse · 2021-07-16T13:44:09Z

src/EnergyPlus/WaterUse.cc

+                        this->TargetTempErrIndex,
+                        this->HotTemp,
+                        this->ColdTemp);
+                }


Catches when Target water temp is > available Hot water temp and throws one time and recurring warning error message.

Nigusse · 2021-07-16T13:46:40Z

src/EnergyPlus/WaterUse.cc

+                        this->TargetTempErrIndex,
+                        this->HotTemp,
+                        this->ColdTemp);
+                }


Catches when Target water temp is < available Cold water temp and throws one time and recurring warning error message.

Nigusse · 2021-07-16T13:49:16Z

tst/EnergyPlus/unit/WaterUse.unit.cc

+    });
+
+    EXPECT_TRUE(compare_err_stream(error_string3, true));
+}


This unit test demonstrates the three conditions where throwing warning error message is warranted. Update the branch, built and ran the unit test locally. Also ran the unit test suite locally and all passed.

Nigusse · 2021-07-16T14:50:16Z

Now there are 35 example files that throw warning error message because they are caught by the fix. But these are expected error messages unless we want to modify the example files to eliminate the warning error. @Myoldmopar

Nigusse · 2021-07-16T15:11:08Z

If the warning error message is a concern another alternative is to not report the warning error message unless "DisplayExtraWarnings" variable is set to true.

mjwitte · 2021-07-19T15:13:17Z

@matthew-larson @Nigusse Ultimately, we want to fix these so the example files deliver the requested target temp without warnings. I would not hide these under "DisplayExtraWarnings". That could happen here or as a sperate defect/PR.

These are are all good warnings that indicate the target temp won't be met, and why. Do we have a warning that checks the supply temp vs target temp directly and warns that it didn't deliver? Or would that even be useful? If all of these checks pass, are there other things that could prevent the target temp from being met?

matthew-larson · 2021-07-19T16:42:09Z

@mjwitte @Nigusse I ended up not doing a check for supply temp vs target temp as this would involve whole different part of the code and I thought would probably be better as a separate issue/pull request. This could probably go along with DHW heating capacity checks which could be the other reason that the target temp wouldn't be reached.

I can go ahead and create another issue/pull request to fix the example files so we can push this one through sooner than later without me holding it up.

Nigusse · 2021-07-19T17:38:37Z

@mjwitte @matthew-larson I suspect sometimes the available capacity and demand mismatch may lead to hot water temperature to drop below the target temperature. But these needs to investigate case by case. I think removing the error message from the example files should be handled in a separate issue.

Nigusse · 2021-07-19T17:59:50Z

@mjwitte I was making comment but ended up closing the issue. That was inadvertent.

Nigusse · 2021-08-25T13:33:46Z

I looked at a couple of example files trying to understand the source and causes of the warning messages. For instance, the example file ReportHeatEmission_RefFSRestaurant.idf has a total of 41 warning massages and these messages occur during warmup period only. There are also two other observations I made:

the warning was issued at Simulation time=07/21 00:00 - 00:15
when I switched the order of the SizingPeriod:DesignDay (summer first) the warning error message occurred at Simulation time=01/21 00:00 - 00:15.
examining the hot water temperature in the tank during these hours indicate the hot water temperature was ~59C, way higher than the target temperature 49C.
This implies there is initialization problem.

@matthew-larson please add timestamp reporting function ShowContinueErrorTimeStamp(state, "") where you added the warning error message code (three locations). This will help us determine if the problem I am seeing is the same across all the example files with error file diffs and it is helpful to have timestamp for future use.

Nigusse · 2021-08-25T13:35:02Z

src/EnergyPlus/WaterUse.cc

+                // print error for variables of hot water temperature
+                ++this->HWTempErrorCount;
+                if (this->HWTempErrorCount < 2) {
+                    ShowWarningError(state, "CalcEquipmentFlowRates: Hot water temperature is less than the cold water temperature");


Add this ShowContinueErrorTimeStamp(state, ""); here

Nigusse · 2021-08-25T13:36:06Z

src/EnergyPlus/WaterUse.cc

+                // print error for variables of target water temperature
+                ++this->TargetTempErrorCount;
+                if (this->TargetTempErrorCount < 2) {
+                    ShowWarningError(state, "CalcEquipmentFlowRates: Target water temperature is greater than the hot water temperature");


Add this ShowContinueErrorTimeStamp(state, ""); here

Nigusse · 2021-08-25T13:36:14Z

src/EnergyPlus/WaterUse.cc

+                // print error for variables of target water temperature
+                ++this->TargetTempErrorCount;
+                if (this->TargetTempErrorCount < 2) {
+                    ShowWarningError(state, "CalcEquipmentFlowRates: Target water temperature is less than the cold water temperature");


Add this ShowContinueErrorTimeStamp(state, ""); here

…-waterusetemp-error

matthew-larson · 2021-08-25T16:00:12Z

Thanks @Nigusse for your review. I went ahead and added the ShowContinueErrorTimeStamp(state, ""); lines as suggested, updated the unit tests accordingly, and merged in the latest develop branch.

Myoldmopar · 2021-09-01T15:53:06Z

I'll pull and test this locally.

Myoldmopar · 2021-09-01T16:46:01Z

Builds and passes locally with develop pulled in. Regressions locally are exactly what it was showing the last time Decent ran. Merging, thanks @matthew-larson and @Nigusse!

matthew-larson · 2021-09-01T17:32:56Z

Thanks @Myoldmopar!

matthew-larson added 10 commits June 7, 2021 10:30

Add warning/error if DHW hot water temperature is less than the cold …

32b5f6a

…water temperature.

Add unit test for hot/cold water temperature comparison.

1e58217

Add warning for DHW water target temperature less than cold water tem…

2df5a64

…perature.

Add warning for DHW target temperature greater than hot water tempera…

c67d6c2

…ture.

Minor updates and new unit test for high DHW target temperature.

b9e817a

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into add…

ac160a6

…-waterusetemp-error

Fix clang formatting.

fc6e69e

Fix clang formatting.

fb547b5

New unit test for low DHW target temperature.

0019e7c

Update description.

857eaa7

matthew-larson added Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Jun 8, 2021

matthew-larson added this to the EnergyPlus 9.6 BugFix Freeze milestone Jun 8, 2021

matthew-larson requested a review from nealkruis June 8, 2021 19:52

matthew-larson self-assigned this Jun 8, 2021

matthew-larson linked an issue Jun 8, 2021 that may be closed by this pull request

No error/warning if DHW hot water temp is less than the cold water temp #8806

Closed

3 tasks

matthew-larson added 2 commits June 8, 2021 15:45

Add EPSILON constant to allow for near-zero comparison values.

6bb1b5d

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into add…

96acdb5

…-waterusetemp-error

matthew-larson marked this pull request as ready for review July 5, 2021 21:58

Nigusse self-requested a review July 16, 2021 13:31

Nigusse approved these changes Jul 16, 2021

View reviewed changes

Nigusse closed this Jul 19, 2021

mjwitte reopened this Jul 19, 2021

Myoldmopar modified the milestones: EnergyPlus 9.6 BugFix Freeze, EnergyPlus 9.6 Release Aug 6, 2021

Nigusse reviewed Aug 25, 2021

View reviewed changes

matthew-larson added 2 commits August 25, 2021 08:48

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into add…

453e101

…-waterusetemp-error

Added timestamp to warning error and updated unit test accordingly.

96162c1

Myoldmopar merged commit 69875d8 into NREL:develop Sep 1, 2021

matthew-larson deleted the add-waterusetemp-error branch September 1, 2021 17:37

This was referenced Sep 20, 2021

Resolve warnings/errors for unreasonable DHW temperatures in Example Files #9075

Closed

Resolve warnings/errors for unreasonable DHW temperatures in Example Files #9078

Merged

asparke2 mentioned this pull request Sep 7, 2022

Unrealistic behavior of Wateruse:Equipment when Hot Water is colder than Cold Water #9650

Closed

3 tasks

mjwitte mentioned this pull request Sep 16, 2022

Corrects WaterUse:Equipment draw behavior when cold water is warmer than hot water #9651

Closed

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warnings/errors for unreasonable DHW temperatures for WaterUse:Equipment #8808

Add warnings/errors for unreasonable DHW temperatures for WaterUse:Equipment #8808

matthew-larson commented Jun 8, 2021

matthew-larson commented Jun 9, 2021

Nigusse Jul 16, 2021

Nigusse Jul 16, 2021

Nigusse Jul 16, 2021

Nigusse Jul 16, 2021

Nigusse commented Jul 16, 2021

Nigusse commented Jul 16, 2021

mjwitte commented Jul 19, 2021

matthew-larson commented Jul 19, 2021

Nigusse commented Jul 19, 2021 •

edited

Loading

Nigusse commented Jul 19, 2021

Nigusse commented Aug 25, 2021 •

edited

Loading

Nigusse Aug 25, 2021 •

edited

Loading

Nigusse Aug 25, 2021

Nigusse Aug 25, 2021

matthew-larson commented Aug 25, 2021

Myoldmopar commented Sep 1, 2021

Myoldmopar commented Sep 1, 2021

matthew-larson commented Sep 1, 2021

Add warnings/errors for unreasonable DHW temperatures for WaterUse:Equipment #8808

Add warnings/errors for unreasonable DHW temperatures for WaterUse:Equipment #8808

Conversation

matthew-larson commented Jun 8, 2021

Pull request overview

Pull Request Author

Reviewer

matthew-larson commented Jun 9, 2021

Nigusse Jul 16, 2021

Choose a reason for hiding this comment

Nigusse Jul 16, 2021

Choose a reason for hiding this comment

Nigusse Jul 16, 2021

Choose a reason for hiding this comment

Nigusse Jul 16, 2021

Choose a reason for hiding this comment

Nigusse commented Jul 16, 2021

Nigusse commented Jul 16, 2021

mjwitte commented Jul 19, 2021

matthew-larson commented Jul 19, 2021

Nigusse commented Jul 19, 2021 • edited Loading

Nigusse commented Jul 19, 2021

Nigusse commented Aug 25, 2021 • edited Loading

Nigusse Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

Nigusse Aug 25, 2021

Choose a reason for hiding this comment

Nigusse Aug 25, 2021

Choose a reason for hiding this comment

matthew-larson commented Aug 25, 2021

Myoldmopar commented Sep 1, 2021

Myoldmopar commented Sep 1, 2021

matthew-larson commented Sep 1, 2021

Nigusse commented Jul 19, 2021 •

edited

Loading

Nigusse commented Aug 25, 2021 •

edited

Loading

Nigusse Aug 25, 2021 •

edited

Loading