-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct array index in IntraZoneNodeData #8796
Conversation
ShowSevereError( | ||
state, | ||
RoutineName + CurrentModuleObject + "='" + Alphas(1) + ": Invalid zone inputs between Node and Link " + Alphas(2) + | ||
" and " + | ||
state.dataAirflowNetwork | ||
->MultizoneZoneData( | ||
state.dataAirflowNetwork->IntraZoneNodeData(state.dataAirflowNetwork->IntraZoneLinkageData(i).NodeNums[0]) | ||
.ZoneNum) | ||
.AFNZoneNum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct array index is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@LipingWang The fix is uploaded. |
ShowSevereError( | ||
state, | ||
RoutineName + CurrentModuleObject + "='" + Alphas(1) + ": Invalid zone inputs between Node and Link " + Alphas(2) + | ||
" and " + | ||
state.dataAirflowNetwork | ||
->MultizoneZoneData( | ||
state.dataAirflowNetwork->IntraZoneNodeData(state.dataAirflowNetwork->IntraZoneLinkageData(i).NodeNums[0]) | ||
.ZoneNum) | ||
.AFNZoneNum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Pulled develop in just to make sure nothing broke with recent changes. Everything built and ran fine. Merging this. Thanks @lgu1234 for the fix and @jasondegraw for the review. |
Pull request overview
The index of ZoneNum used in IntraZoneNodeData array is replaced by AFNZoneNum. The program runs completion.
A test file is uploaded.
NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.