Workflow code that run topmodel within ngen Framework #42
Conversation
| mod-dir: "extern/cfe/" | ||
| targets: "cfebmi" | ||
|
|
||
| - name: Build PET |
There was a problem hiding this comment.
I don't see PET being used in any of the ngen runs here.
There was a problem hiding this comment.
No, it is not so can be removed.
|
|
||
| - name: Run Ngen Test | ||
| run: | | ||
| # Run ngen with topmodel with CFE |
There was a problem hiding this comment.
Again, this realization couples noahowp & cfe.
Is a topmodel & CFE coupling even sensible/common? @SnowHydrology
It's probably best to throw PET somewhere in the mix. The lib is being built, but not currently used. @stcui007 - I believe I have a bmi_multi_pet_topmodel realization around somewhere if that helps. -thanks again.
There was a problem hiding this comment.
Tha comment is incorrect. I think it is either topmodel or CFE.
There was a problem hiding this comment.
Could try to see if you can find your realization file coupling PET with Topmodel? That would save me time if there are intricacies involved. Thanks.
* testing ngen workflow with tmod-pet * pet config is format ini * pet lib path fix * move topmod data dir? * tmod var map adjust * re-add surfacebmi+topmod run --------- Co-authored-by: Jessica Garrett <[email protected]>
This PR provides a workflow code that incorporate topmodel into the ngen framework by running automated ngen test with topmodel commits.
Additions
.github/workflows/ngen_integration.yaml
data/realization_config_topmodel_ngenCI.json
Removals
Changes
Testing
Passded all automated testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other