Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-cfe2.0_cleanup #121

Merged
merged 18 commits into from
Jul 9, 2024
Merged

pre-cfe2.0_cleanup #121

merged 18 commits into from
Jul 9, 2024

Conversation

ajkhattak
Copy link
Contributor

A few things have been cleaned up (moved/removed) before the cfe2.0 release. No changes to the code.

Additions

  • no additions

Removals

  • removed params directory, which is neither needed nor directly related to cfe code.

Changes

  • config files related to aorc, pet, and SoilMoistureProfiles models are moved to their respective repos
  • Updated documentation
  • CFE2.0 test added to ngen CI

Testing

  1. Results before and after these changes are unchanged.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@ajkhattak ajkhattak mentioned this pull request Jul 2, 2024
Draft
@ajkhattak
config files cleanup, moved aorc and pet files to their respective re…
d8cba1e 
…pos.
@ajkhattak
removed files that are either no longer needed or not necessary.
911a0fa
@ajkhattak
removed more files.
bcdfba2
@ajkhattak
updated documentation and realization files.
9d8d4ec
@ajkhattak
updated realization files.
4241400
@ajkhattak
added cfe2.0 to ngen CI test
24d05e9
@ajkhattak
nash_cascade changes to nash_casdace_surface and nash_casdace_subsurf…
41d4f8b 
…ace, and a few other minor changes.
@ajkhattak
updated config files for cfe2.0, check if nash storage is zero then s…
dd02e06 
…kip the iteration.
@ajkhattak
modified names for Nash cascade subsurface to make it consistent with…
d1e44cf 
… Nash cascade surface.
@ajkhattak
removed *_surfnash.txt file from cfe1.0 folder.
fe7fc2b
@ajkhattak
updated giuh realization file.
b28b5e2
@ajkhattak
updated config files and printf statements with more detials when non…
17212cb 
…-optional params are missing.
@ajkhattak
updated submodules.
1a24983
@ajkhattak
updated unittest, realization file, and changed K_infiltration to Kin…
eb83249 
…f_nash_surface for consistency.
@ajkhattak
updated git action to checkout PET master for testing, initalize num_…
7647ba3 
…giuh_ordinate to zero to avoid garbage when runoff scheme is NASH_CASCADE.
@ajkhattak
minor changes.
090e5e7
@ajkhattak
Update ngen_integration.yaml
42dea3c
madMatchstick
madMatchstick reviewed Jul 8, 2024
View reviewed changes
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Show resolved Hide resolved
madMatchstick
madMatchstick approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@madMatchstick madMatchstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the entire install.md for good measure. Looks good to me.

@ajkhattak ajkhattak merged commit 012ffbb into master Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madMatchstick madMatchstick madMatchstick approved these changes

@rlmcdaniel rlmcdaniel Awaiting requested review from rlmcdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajkhattak @madMatchstick