generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect unit for RAIN_RATE ouput #58
Comments
ajkhattak
added a commit
that referenced
this issue
Aug 29, 2024
ajkhattak
added a commit
that referenced
this issue
Aug 30, 2024
ajkhattak
added a commit
that referenced
this issue
Sep 4, 2024
ajkhattak
added a commit
that referenced
this issue
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The output defined as RAIN_RATE in output_var_names has unit of m ( see [https://github.com/NOAA-OWP/cfe/blob/39c18a100dcb5c664900711c8f65f786642f0671/src/bmi_cfe.c#L203]) according to the bmi functions, but the output actually is in mm.
Current behavior
Incorrect unit (mm) for RAIN_RATE output.
Expected behavior
RAIN_RATE in m
Suggested fix:
Since all other variables are in m, we probably want to keep this variable in m, and convert the variable from mm to m within the code.
The text was updated successfully, but these errors were encountered: