Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected unit warning to relevant configuration parameters #125

Closed
aaraney opened this issue Aug 14, 2024 · 0 comments · Fixed by #129
Closed

Add expected unit warning to relevant configuration parameters #125

aaraney opened this issue Aug 14, 2024 · 0 comments · Fixed by #129
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@aaraney
Copy link
Member

aaraney commented Aug 14, 2024

Some parameters added around the time of #120 do not warn in units are not included if CFE_DEBUG is enabled. Thoughts on adding these warnings?

Im sure i've missed some, but here are the ones that came to mind:

retention_depth_nash_surface -> [m]
Kinf_nash_surface -> [h^-1]
nash_storage_surface -> [m]
K_nash_surface -> [h^-1]

@aaraney aaraney added the enhancement New feature or request label Aug 14, 2024
@aaraney aaraney added the question Further information is requested label Aug 14, 2024
ajkhattak added a commit that referenced this issue Aug 29, 2024
ajkhattak added a commit that referenced this issue Aug 30, 2024
@ajkhattak ajkhattak mentioned this issue Sep 3, 2024
7 tasks
ajkhattak added a commit that referenced this issue Sep 4, 2024
ajkhattak added a commit that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants