Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modulefiles on rrfs_ci #170

Closed
wants to merge 4 commits into from

Conversation

robgpita
Copy link

@robgpita robgpita commented Jul 19, 2022

DESCRIPTION OF CHANGES:

  • This PR refactors modulefiles/build_aws_intel to use srw_common to build & modulefiles/wflow_aws has been modified to correctly load rocoto and allow the miniconda3 installation to be discoverable.
  • In using srw_common, a couple of hpc-stack libraries were updated( ec15cd7 ) on the self-hosted runner machine.
  • build.yml is removed, as the workflow fails (we do not maintain the ncar self hosted runner).

TESTS CONDUCTED:

A Build test was successful on a self-hosted runner by attaching the ci-aws-intel-build label to this PR. Results of the GitHub Actions workflow can be found here: https://github.com/NOAA-GSL/ufs-srweather-app/actions/runs/2700522057.

DEPENDENCIES:

None

DOCUMENTATION:

This PR does not contribute any new changes that need to be documented.

CONTRIBUTORS (optional):

@christinaholtNOAA @venitahagerty @christopherwharrop-noaa

AWS ParallelCluster user added 2 commits July 14, 2022 16:48
… in the regional_workflow to run the build tests in that repository.
… into feature/CI_WE2E_tests & remove workflows/build.yml
@robgpita robgpita added the ci-aws-intel-build Kicks of automated build test on aws self hosted runner label Jul 19, 2022
@robgpita robgpita added ci-aws-intel-build Kicks of automated build test on aws self hosted runner and removed ci-aws-intel-build Kicks of automated build test on aws self hosted runner labels Jul 19, 2022
@venitahagerty
Copy link

I looked through the code changes, and the Action steps. I'm curious as to the use of /scratch1. That's on AWS?

Also, what does the "Check Build Sucess or failure step" do? I didn't find the output to be very descriptive.

@robgpita
Copy link
Author

@venitahagerty Yes, /scratch1 is the mount point for the Lustre FS on AWS (where miniconda and hpc-stack are installed, and where the End to End Tests are submitted from to use the compute nodes). Build_Status is the final job which ultimately dictates the build status, displayed in the Github Actions UI. It is necessary to have this final job in the GHA workflow to check whether the build was successful or not, in checking the log emitted by ./build.sh. Without the final Build_Status job, the build (and the GHA workflow) will always appear to succeed, because the previous job (Build_SRWA) only calls ./build.sh, which does not exit on failure or success.

Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a broader scope question to think about below.

@@ -1,21 +0,0 @@
name: Build SRW
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any ideas on strategies about how we might be able to manage GSL workflows alongside authoritative ones? (A question we can definitely dive into more in the wrap up)

@christinaholtNOAA
Copy link
Collaborator

OBE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-aws-intel-build Kicks of automated build test on aws self hosted runner
Projects
None yet
4 participants