Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE! Highlights the RRFS_dev diffs #168

Draft
wants to merge 77 commits into
base: dev_tmp_rrfs_merge
Choose a base branch
from

Conversation

christinaholtNOAA
Copy link
Collaborator

This PR is meant as an open forum to discuss differences that we have in the RRFS_dev branch.

We will use this comparison to isolate features that will be contributed to the real develop branch.

This PR is for demo purposes only!

SamuelTrahanNOAA and others added 30 commits May 5, 2021 23:01
…or Spring Experiment.

2) Set
      allow_wet_snow = .true.
      allow_wet_graupel = .false.
      melti=.true.
   for all steps.
RRFS_dev: fix problems in reflectivity diagnosis for Thompson scheme.
…o old version

In ruclsm: a tuning
In module_sf_mynn.F90: remove NSST.
Put several hot fix to ccpp for RRFS 2022 HWT
Modified physics/drag_suite.F90 to remove topographic limitations on small-scale GWD and TOFD
…FS_dev-20220314

Merge gsl/develop to RRFS_dev
1. Added lat/lon to the parameter list for debugging purposes.
2. Flag_restart is replaced with lsm_cold_start.
3. Removed snow initialization with the use of RUC LSM. In case of cold
start snow on land andice is initialized in io/FV3GFS_io.F90. In case of
warm start, these variables are carried along.
3. Corresponding changes in GFS_surface_composites.meta.
The change gets around snow initialization with the use of RUC LSM
…ites_bugfixes

Bug fixes to drag_suite.F90 and GFS_surface_composites.F90
merging MYNN mods from gsl/develop
…s a flux-based

diagnostics. This diagnostics will be enabled when MYNN surface layer
scheme and RUC LSM are used in the physics suite, for example FV3_HRRR suite.
2. In sfc_drv_ruc.F90 several variables are added to the output. They
include such variables as variable-density snow accumulation, accumulated snow melt,
latent heat flux due to snow phase changes, sublimation, direct evaporation, canopy evaporation and
transpiration fluxes. Fixed units of runoff variables.
3. Cleaned-up print statements. Introduced a test point with
lat/lon for debugging in sfc_diag.f, sfc_drv_ruc.F90 and
module_sf_ruclsm.F90.
4. Several modifications to the snow model in module_sf_ruclsm.F90.
Introduced two options to compute snow fraction and thermal conductivity
in snow. The new options are disabled until their impact is evaluated in
the retrospective experiments.
Added Glacier land-use type to set_soilveg_ruc.F90
Zero out snowfallacc_lnd/ice at the beginning of the free forecast.
Removed zeroing out the state variables at the beginning of the
forecast.
SamuelTrahanNOAA and others added 29 commits June 15, 2022 14:42
Bug fixes to prevent crashes and other failures.
Unify the FV3-HRRR and FV3-HRRR-smoke
1) add a special treatment to melting hail on the ground after hail storm.
2) moved parameter for snow over and conductivity definition to the top
update physics for RRFS baseline E
update smoke emission reading and direct feedback
zhanglikate pushed a commit to zhanglikate/ccpp-physics that referenced this pull request Apr 5, 2024
…pliant

Make ozone physics CCPP compliant by removing 'optional' and 'pointer' attributes (includes NOAA-GSL#168 and NOAA-GSL#169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants