HFIP 2022 Hannah Update 2 #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, additional code updates and bugs
hannahcbarnes
requested review from
SamuelTrahanNOAA,
tanyasmirnova,
christinaholtNOAA,
joeolson42,
mdtoyNOAA,
haiqinli,
zhanglikate and
middlecoff
as code owners
This was referenced Sep 14, 2022
|
@haiqinli Can you look double check these modifications? |
mdtoyNOAA
approved these changes
Sep 14, 2022
|
@hannahcbarnes The variable of aod_da should be added into cu_gf_driver.meta. The others look good. Thanks. |
|
@haiqinli thanks. aod_da should now be a part of cu_gf_driver.meta |
haiqinli
approved these changes
Sep 15, 2022
- Minor fixes to pass regression tests
joeolson42
reviewed
Oct 21, 2022
physics/sgscloud_radpre.F90
Outdated
| @@ -90,7 +92,8 @@ subroutine sgscloud_radpre_run( & | |||
| real(kind=kind_phys), dimension(:,:), intent(inout) :: qr, qs, qg | |||
| ! qci_conv only allocated if GF is used | |||
| real(kind=kind_phys), dimension(:,:), intent(inout) :: qci_conv | |||
| real(kind=kind_phys), dimension(:,:), intent(in) :: ud_mf | |||
| real(kind=kind_phys), dimension(:,:), intent(in) ::ud_mf | |||
| real(kind=kind_phys), dimension(:,:), intent(in) ::ud_mf_timeave, qci_conv_timeave | |||
There was a problem hiding this comment.
minor detail but can we preserve the space between :: and the first variable?
joeolson42
reviewed
Oct 21, 2022
| @@ -328,12 +331,13 @@ subroutine sgscloud_radpre_run( & | |||
| else ! scaling function (CB2005) | |||
| f = 1.0 | |||
| endif | |||
| sigq = 1.5E-3 * ud_mf(i,k)/dt * f | |||
| sigq = ud_mf_timeave(i,k)/dt * f | |||
| !sigq = 1.5E-3 * ud_mf(i,k)/dt * f | |||
There was a problem hiding this comment.
This is a bit shocking. Are you sure sigq will be ~O(1e-4) without this constant? If sigq is too big, you might always get cloud fractions of around 50%,
There was a problem hiding this comment.
I can check. I have output arrays of just GF cloud fraction. Where there are clouds, cloud fraction values tend to be between 30-70%.
joeolson42
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables GF to use AOD analysis instead of AOD from MERRA2 climatology
Fixes GF - radiation coupling
Fixes dry / moist mixing ratios in GF
Additional tuning to GF
Reverts previous change to sgscloud_radpre
The regression test logs are in /scratch1/BMC/gsd-fv3-dev/hcbarnes/CommitTest/sorc/ufs_model.fd/tests/