Fix calculation of Pacific Equatorial Undercurrent transport #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huan Gao and Rong Zhang noted that the transport in the equatorial undercurrent should be around ~24 Sv in the annual mean, but in the actual diagnostic after postprocessing, it was around -8Sv. This was traced down to errors in the strait_transport_timeseries. This commit fixes the logical and indexing errors in that script namely in the way that the z-index to integrate to and the zeroing out of any deeper layers. For the year 650 of the CM4 PI-Control experiment, the routine now returns an annually averaged transport of 25 Sv.
|
I tested the changes here manually by calling However, I'm not sure if there's an alternate testing pipeline for the refineDiag part of the postprocessing in general to make sure that it didn't break anything else. Do you know @jkrasting? |
|
@jkrasting Do you know if this has been tested? |
|
@jkrasting Bump |
|
This PR is labelled "draft" presumably because it wasn't tested in the workflow. I'm still waiting to hear whether this has been tested. @jkrasting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huan Gao and Rong Zhang noted that the transport in the equatorial
undercurrent should be around ~24 Sv in the annual mean, but in
the actual diagnostic after postprocessing, it was around -8Sv. This
was traced down to errors in the strait_transport_timeseries.
This commit fixes the logical and indexing errors in that script namely
in the way that the z-index to integrate to and the zeroing out of any
deeper layers. For the year 650 of the CM4 PI-Control experiment, the
routine now returns an annually averaged transport of 25 Sv.