Skip to content

Commit

Permalink
+Idealized_hurricane input parameter updates
Browse files Browse the repository at this point in the history
  Revised some of the settings in the MOM_input file for SCM_idealized_hurricane
to reflect how this configuration works.  Also added commented out settings in
the MOM_override for this test case to reflect the settings that would be needed
to give mathematically equivalent answers using the more standard "ideal_hurr"
value WIND_CONFIG, rather than "SCM_ideal_hurr".  This configuration will be
revised once some pending changes to the user/Idealized_hurricane.F90 code
are in place.  The answers in the SCM_idealized_hurricane test case are bitwise
identical.

  Also modified the MOM_input file for the idealized_hurricane test case to
avoid using IDL_HURR_SCM_BR_BENCH = True, which recreates an obvious bug, and
adds an as-yet unused parameter that will allow this test case to work as
intended with the pending code changes to Idealized_hurricane.F90.  This
change does change answers in that case, but it does not impact any of our usual
regression testing.

  The MOM_parameter_doc files were also updated for both the idealized_hurricane
test cases.
  • Loading branch information
Hallberg-NOAA authored and marshallward committed Apr 26, 2024
1 parent 582385d commit d7a67d2
Show file tree
Hide file tree
Showing 9 changed files with 136 additions and 120 deletions.
5 changes: 5 additions & 0 deletions ocean_only/SCM_idealized_hurricane/MOM_input
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,11 @@ WIND_CONFIG = "SCM_ideal_hurr" ! default = "zero"
! options include (file), (2gyre), (1gyre), (gyres), (zero), and (USER).

! === module idealized_hurricane ===
IDL_HURR_SCM_BR_BENCH = True ! default = False
! Single column mode benchmark case switch, which is invoking a modification
! (bug) in the wind profile meant to reproduce a previous implementation.
IDL_HURR_SCM = True ! [Boolean] default = False
! Single Column mode switch used in the SCM idealized hurricane wind profile.

! === module MOM_main (MOM_driver) ===
DAYMAX = 3.0 ! [days]
Expand Down
23 changes: 23 additions & 0 deletions ocean_only/SCM_idealized_hurricane/MOM_override
Original file line number Diff line number Diff line change
@@ -1 +1,24 @@
! Blank file in which we can put "overrides" for parameters

! These parameters give a configuration that is mathematically equivalent to the SCM test case.
! #override WIND_CONFIG = "ideal_hurr" ! default = "zero"
! ! The character string that indicates how wind forcing is specified. Valid
! ! options include (file), (2gyre), (1gyre), (gyres), (zero), and (USER).
! IDL_HURR_SCM_BR_BENCH = True ! default = False
! ! Single column mode benchmark case switch, which is invoking a modification
! ! (bug) in the wind profile meant to reproduce a previous implementation.
! IDL_HURR_SCM = True ! [Boolean] default = False
! ! Single Column mode switch used in the SCM idealized hurricane wind profile.
! IDL_HURR_X0 = 6.48E+05 ! [m] default = 0.0
! ! Idealized Hurricane initial X position
! IDL_HURR_SCM_EDGE_TAPER_BUG = True ! [Boolean] default = False
! ! If true and IDL_HURR_SCM is true, use a bug that does all of the tapering and
! ! inflow angle calculations for radii between RAD_EDGE and RAD_AMBIENT as though
! ! they were at RAD_EDGE.
! IDL_HURR_RAD_AMBIENT = 12.0 ! [nondim] default = 12.0
! ! Radius at which the winds are at their ambient background values, normalized
! ! by the radius of maximum winds.
! IDL_HURR_ANSWER_DATE = 99991231 ! default = 99991231
! ! The vintage of the expressions in the idealized hurricane test case. Values
! ! below 20190101 recover the answers from the end of 2018, while higher values
! ! use expressions that are rescalable and respect rotational symmetry.
4 changes: 2 additions & 2 deletions ocean_only/SCM_idealized_hurricane/MOM_parameter_doc.all
Original file line number Diff line number Diff line change
Expand Up @@ -1573,10 +1573,10 @@ IDL_HURR_Y0 = 0.0 ! [m] default = 0.0
! Idealized Hurricane initial Y position
IDL_HURR_TAU_CURR_REL = False ! [Boolean] default = False
! Current relative stress switch used in the idealized hurricane wind profile.
IDL_HURR_SCM_BR_BENCH = False ! [Boolean] default = False
IDL_HURR_SCM_BR_BENCH = True ! [Boolean] default = False
! Single column mode benchmark case switch, which is invoking a modification
! (bug) in the wind profile meant to reproduce a previous implementation.
IDL_HURR_SCM = False ! [Boolean] default = False
IDL_HURR_SCM = True ! [Boolean] default = False
! Single Column mode switch used in the SCM idealized hurricane wind profile.
IDL_HURR_SCM_LOCY = 5.0E+04 ! [m] default = 5.0E+04
! Y distance of station used in the SCM idealized hurricane wind profile.
Expand Down
5 changes: 5 additions & 0 deletions ocean_only/SCM_idealized_hurricane/MOM_parameter_doc.short
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,11 @@ WIND_CONFIG = "SCM_ideal_hurr" ! default = "zero"
! (SCM_CVmix_tests) and (USER).

! === module idealized_hurricane ===
IDL_HURR_SCM_BR_BENCH = True ! [Boolean] default = False
! Single column mode benchmark case switch, which is invoking a modification
! (bug) in the wind profile meant to reproduce a previous implementation.
IDL_HURR_SCM = True ! [Boolean] default = False
! Single Column mode switch used in the SCM idealized hurricane wind profile.

! === module MOM_main (MOM_driver) ===
DAYMAX = 3.0 ! [days]
Expand Down
5 changes: 4 additions & 1 deletion ocean_only/idealized_hurricane/MOM_input
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,10 @@ IDL_HURR_X0 = 3.432E+06 ! [m] default = 0.0
! Idealized Hurricane initial X position
IDL_HURR_Y0 = 9.0E+05 ! [m] default = 0.0
! Idealized Hurricane initial Y position
IDL_HURR_SCM_BR_BENCH = True ! default = False
IDL_HURR_RAD_AMBIENT = 15.0 ! [nondim] default = 12.0
! Radius at which the winds are at their ambient background values, normalized
! by the radius of maximum winds.
IDL_HURR_SCM_BR_BENCH = False ! default = False
! Single column mode benchmark case switch, which is invoking a modification
! (bug) in the wind profile meant to reproduce a previous implementation.

Expand Down
Loading

0 comments on commit d7a67d2

Please sign in to comment.