Combination CCPP-related PR for ozone diagnostics, metadata intent bugfixes, sfcsub.F landmask bugfix, and canopy resistance output #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2024
|
I think that CI failed because I forgot to push the latest ccpp-physics commit before I pushed the fv3atm commit that triggered the tests. |
DusanJovic-NOAA
approved these changes
May 16, 2024
|
@BrianCurtis-NOAA are you able to review this PR? |
jkbk2004
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR combines changes from 4 ccpp-physics PRs. See ufs-community/ccpp-physics#205
Other than ccpp-physics submodule updates, this PR has:
rcais used for Noah and Noahmp LSMsuse_2m_diagnostics_calculated_by_lake_modelto reflect the Fortran codeReplaces: #827 and #830
Issue(s) addressed
ufs-community/ccpp-physics#199
#829
Testing
See ufs-community/ufs-weather-model#2264 for UFS regression testing on Hera.
Dependencies
ufs-community/ccpp-physics#205