Changes to Logging and Initialization of the CLM Lake Model #681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the work of @tanyasmirnova to fix some initialization issues in the CLM Lake Model. Initialization appears to work correctly without fractional ice. There are some lingering issues with fractional ice initialization that we're working on.
Changes:
frac_ice=.false.
in the gfs_physics namelist.lake_q2m
in GFS_diagnostics.F90Issue(s) addressed
Testing
How were these changes tested?
Staged test case on Hera.
What compilers / HPCs was it tested with?
Hera intel & gnu
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes, the tests already exist.
Have the ufs-weather-model regression test been run? On what platform?
Yes, but this is not the final version of the code. I'll rerun them again when we're finished.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Any tests that use clm lake with lake data will change results due to the changes to clm lake initialization.
Please commit the regression test log files in your ufs-weather-model branch
Will do.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs