Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ice fraction needs to be truncated to values < 1.0 #38

Closed
DeniseWorthen opened this issue Jan 9, 2020 · 1 comment
Closed

ice fraction needs to be truncated to values < 1.0 #38

DeniseWorthen opened this issue Jan 9, 2020 · 1 comment

Comments

@DeniseWorthen
Copy link
Collaborator

When running in coupled mode, the ice fraction imported from the mediator can be greater than 1. This is non-physical and results in a seg fault when the (1-fice) is used to calculate the surface stress3.

In atmos_model, the imported ice fraction needs to be bounded to be strictly between zero and one:

IPD_Data(nb)%Coupling%ficein_cpl(ix) = max(zero,min(datar8(i,j),one))

This is a bugfix and is expected to change answers in the coupled model but have no impact on standalone.
@DeniseWorthen DeniseWorthen mentioned this issue Jan 9, 2020
Closed
@DeniseWorthen DeniseWorthen mentioned this issue Jan 20, 2020
Merged
@junwang-noaa
Copy link
Collaborator

Code is committed, close issue.

climbfuji added a commit to climbfuji/fv3atm that referenced this issue Apr 10, 2020
@climbfuji
Merge pull request NOAA-EMC#38 from climbfuji/dtc_hwrf-physics_add_rrtmg
fd70a2c 
dtc/hwrf-physics: HWRF RRTMG (based on NOAA-EMC#33)
climbfuji pushed a commit to climbfuji/fv3atm that referenced this issue Jun 29, 2020
@DomHeinzeller
Merge pull request NOAA-EMC#38 from climbfuji/update_gsd_develop_from…
6f26ccf 
…_dev_emc_20200625

Update gsd/develop from develop 2020/06/25 and mods to MYNN sfc and PBL for fractional/coupled
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this issue Nov 17, 2023
@DusanJovic-NOAA
Merge pull request NOAA-EMC#38 from DusanJovic-NOAA/merge_gfdl_dev_emc
2cbdb7c 
Merge dev/emc branch from upstream (NOAA-GFDL/GFDL_atmos_cubed_sphere)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junwang-noaa @DeniseWorthen