Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R21B in IC4 #1176

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Commits on Jan 12, 2024

  1. This is for the issue "R21B to IC4 subroutine"

    I have ported my changes from COAMPS/WW3 (which is v6.07) to my fork, branch "1167-R21B-in-IC4" (which is version 7.14+).
    Changes are made to 4 of the WW3 fortran files.'
    I needed to do the merge manually, since there are a lot of formatting changes (etc.) going from 6.07 to 7.14.
    ErickRogers committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8646574 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Branch=1167-R21B-in-IC4

    Adding regtest for IC4M8 and IC4M9
    Examples:
    cd $REGTESTDIR
    ./bin/run_test -i input_IC4_M8 -w work_IC4_M8 $MODELDIR ww3_tic1.1
    ./bin/run_test -i input_IC4_M9 -w work_IC4_M9 $MODELDIR ww3_tic1.1
    
    I also edited the info file.
    
    I did not include ww3_shel.nml for these regtests, since this feature is apparently broken. I did include the other .nml files.
    (Specifics about the thing that is broken: the option to have homogeneous input field in ww3_shel.nml. Either it is broken in the code, or it is broken in the examples provided for IC4M1, IC4M2, IC4M3, IC4M4, IC4M5, IC4M7. Regtest IC4M6 *does* run with ww3_shel.nml, since it does not use any homogeneous input field. Failure mode: seg fault)
    In any case, regtest with -N with these new regtests will only run if you exclude ww3_shel.nml using -r or -q options of run_test.
    
    Regtests w/out -N *do* work, for all cases.
    ErickRogers committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d4640ab View commit details
    Browse the repository at this point in the history
  2. Branch=1167-R21B-in-IC4

    Merge from develop.
    There was a conflict in a single line.
    Someone added “,END=801,ERR=802,IOSTAT=IERR” on an IC4-related line.
    Conflict resolved by incorporating both edits.
    
    Merge remote-tracking branch 'upstream/develop' into 1167-R21B-in-IC4
    ErickRogers committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    24f2351 View commit details
    Browse the repository at this point in the history
  3. branch=1167-R21B-in-IC4

    Adding IC4M8 and IC4M9 regtests (one each) to matrix.base
    ErickRogers committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    92f5c3a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Branch=1167-R21B-in-IC4. Here, I add updates to the manual. I also up…

    …date the documentation in fortran code and regtest to be consistent with naming convention used in the manual (using the 2021a 2021b convention outside the manual is risky because Latex assigns the a and b and it may not be what one has in mind, so I don't use that anymore.)
    ErickRogers committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e02ea98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b79a236 View commit details
    Browse the repository at this point in the history