Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multi_gases to 32 bit compiling #19

Merged

Conversation

XiaqiongZhou-NOAA
Copy link
Collaborator

To fix the issue to run the 32-bit multi_gases option.
Related pull requests:
ufs-community/ufs-weather-model#112
NOAA-EMC/fv3atm#108
NCAR/ccpp-physics#444

@@ -1958,7 +1962,13 @@ subroutine atmos_phys_driver_statein (IPD_Data, Atm_block,flip_vc)
!$OMP shared (Atm_block, Atm, IPD_Data, npz, nq, ncnst, sphum, liq_wat, &
!$OMP ice_wat, rainwat, snowwat, graupel, pk0inv, ptop, &
!$OMP pktop, zvir, mygrid, dnats, nq_adv, flip_vc) &
#ifdef MULTI_GASES

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can delete the space lines later?

Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 2f116fd into NOAA-EMC:dev/emc Jul 7, 2020
tsupinie pushed a commit to tsupinie/GFDL_atmos_cubed_sphere that referenced this pull request Jul 20, 2020
* Fix for multi_gases to 32 bit compiling
* Add a subroutine to read multi_gases_nml to be consistent with others
* Replace rilist and cpilist with ri and cpilist for multi_gases_nml
tsupinie pushed a commit to tsupinie/GFDL_atmos_cubed_sphere that referenced this pull request Jul 20, 2020
* Fix for multi_gases to 32 bit compiling
* Add a subroutine to read multi_gases_nml to be consistent with others
* Replace rilist and cpilist with ri and cpilist for multi_gases_nml
aerorahul pushed a commit that referenced this pull request Jul 17, 2021
* Add LICENSE.md

* Renamed driver directories and removed the null version of the nh extensions for the public release

* Update license header for FV3

* Added a README.md file

* Replace GPL header with LGPL header

* fixed license header in every file and added it to those without it

* commit of new version of dycore from Weather and Climate Dynamics Group at GFDL

* updated README.md with current release information

* updated message for gfdl version of FV3

* fixed merge issues with fv_diagnostics.F90

* remove trailing spaces from sources

* remove extra file

* changes necessary for updated FMS diag_manager

* Master test (#17)

* commit of new version of dycore from Weather and Climate Dynamics Group at GFDL

* updated versions of GFDL-specific files from dev/gfdl

* updated README.md with current release information

* cleaned up a few lines in fv_dynamics

* new file RELEASE.md with release notes documenting differences between this and the last release

* updated RELEASE.md message

* hand merge of diagnostic updates

* remove trailing spaces from sources

* updates to merge some GFDL specific updates into this public release

* Master test (#18)

* commit of new version of dycore from Weather and Climate Dynamics Group at GFDL

* updated versions of GFDL-specific files from dev/gfdl

* updated README.md with current release information

* cleaned up a few lines in fv_dynamics

* new file RELEASE.md with release notes documenting differences between this and the last release

* updated RELEASE.md message

* hand merge of diagnostic updates

* remove trailing spaces from sources

* updates to merge some GFDL specific updates into this public release

* updated README.md

* updated GFDL_tools/fv_cmip_diag to be consistent with dev/gfdl branch

* remove tab characters from source files

* fixed comment in the README

Co-authored-by: Seth Underwood <[email protected]>
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA deleted the dev/rt_multigases branch March 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants