Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need additional include flags for GNU compiler #31

Closed
climbfuji opened this issue Jul 1, 2020 · 1 comment · Fixed by #34
Closed

Need additional include flags for GNU compiler #31

climbfuji opened this issue Jul 1, 2020 · 1 comment · Fixed by #34

Comments

@climbfuji
Copy link

For some users and/or on some systems, the recent dycore update requires adding an additional include flag in the top-level makefile:

dom.heinzeller@heinzeller-lt:~/scratch/ufs-weather-model/ufs-weather-model-jun-tomsfix-20200626/FV3/atmos_cubed_sphere [gnupy3dev]> git diff
diff --git a/makefile b/makefile
index 530a73d..e35a9ba 100644
--- a/makefile
+++ b/makefile
@@ -23,7 +23,7 @@ endif

 LIBRARY  = libfv3core.a

-FFLAGS   += -I$(FMS_DIR) -I../gfsphysics -I../ipd -I../io
+FFLAGS   += -I$(FMS_DIR) -I../gfsphysics -I../ipd -I../io -I.

 SRCS_f   =

Without these, users may get an error message

tools/fv_eta.F90:291:2:

  291 |
      |  1
Fatal Error: tools/fv_eta.h: No such file or directory
compilation terminated.
../conf/make.rules:20: recipe for target 'tools/fv_eta.o' failed
gmake[2]: *** [tools/fv_eta.o] Error 1
@climbfuji
Copy link
Author

This was fixed in the NCAR dtc/develop branch in PR NCAR#14, commit cbbf2e8. This can be cherry-picked and committed to dev/emc if needed.

DusanJovic-NOAA pushed a commit that referenced this issue Jul 23, 2020
- add additional include flags for GNU compiler (fixes #31)
- bugfix in `model/multi_gases.F90`: add missing import (use) statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant