Source maps support #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzzy
commented
Jun 22, 2018
| const processOptions = Object.assign( | ||
| { from: assetName, to: assetName }, | ||
| this.options.cssProcessorOptions || {} | ||
| this.options.cssProcessorOptions |
There was a problem hiding this comment.
From MDN:
Note that Object.assign() does not throw on
nullorundefinedsource values.
frenzzy
commented
Jun 22, 2018
| @@ -30,33 +30,36 @@ class OptimizeCssAssetsWebpackPlugin extends LastCallWebpackPlugin { | |||
| } | |||
|
|
|||
| processCss(assetName, asset, assets) { | |||
| const css = asset.source(); | |||
| const css = asset.sourceAndMap ? asset.sourceAndMap() : { source: asset.source() }; | |||
There was a problem hiding this comment.
UglifyJS Webpack Plugin also uses sourceAndMap function if exists
frenzzy
commented
Jun 22, 2018
| (map.mappings && map.mappings.length > 0) | ||
| ) | ||
| ) { | ||
| processOptions.map = Object.assign({ prev: map }, processOptions.map); |
There was a problem hiding this comment.
From PostCSS docs:
prevstring, object, boolean or function: source map content from a previous processing step (for example, Sass compilation). PostCSS will try to read the previous source map automatically (based on comments within the source CSS), but you can use this option to identify it manually. If desired, you can omit the previous map withprev: false.
|
Thx for the help |
jasononeil
added a commit
to cultureamp/optimize-css-assets-webpack-plugin
that referenced
this pull request
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53