NetworkTarget - UdpNetworkSender changed to QueuedNetworkSender

[snakefoot]

Now performs "ordered" message split, so UDP network-packets will be sent in the order they have been logged (even when split into chunks). It will have the side-effect that if an UDP-socket fails, then all pending messages in queue will be marked as failed.

For TCP-network-senders then it removes the memory-allocation of the message-chunking-delegate (TCP network senders does not need help with splitting large messages).

[304NotModified]

Will try to review next week. Now on holiday. Feel free to remind me :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

82.9% Coverage
0.0% Duplication

[304NotModified]

Looks good to me!

[snakefoot]

Looks like the unit-test need more work:

[xUnit.net 00:01:45.27]     NLog.UnitTests.Targets.NetworkTargetTests.NetworkTargetUdpTest(splitMessage: True) [FAIL]
  Failed NLog.UnitTests.Targets.NetworkTargetTests.NetworkTargetUdpTest(splitMessage: True) [77 ms]
  Error Message:
   Message #99 not received.
Expected: True
Actual:   False
  Stack Trace:
    at NLog.UnitTests.Targets.NetworkTargetTests.NetworkTargetUdpTest (System.Boolean splitMessage) [0x0021f] in <de11e80b67cd4315bb1f1a86a536ccd7>:0 
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <533173d24dae460899d2b10975534bb0>:0 

https://ci.appveyor.com/project/nlog/nlog/builds/40725702/job/qgwfdds2hkvxgjtx

More logging maybe to reveal what happens, since package drop is allowed with UDP.