BaseDirLayoutRenderer - Improve FixTempDir on Linux when TMPDIR is not set #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55dce1d
to
230f2c7
Compare
230f2c7
to
e9ebc93
Compare
e9ebc93
to
2f7360d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
We wait for #3899 (comment) before merging this, isn't? |
No opinion. Very certain that the PR will resolve the issue. |
|
waiting for #3899 |
Don't think you will get a confirmation, as there was too many obstacles (Including the infamous NLog.config-nuget-package). Just have to trust me that this PR will improve SingleFilePublish behavior on Linux-platform. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GetTempPath on Linux (Uses
/tmp/as only fallback):https://github.com/dotnet/coreclr/blob/6ba74dc2a7194f8d6c86c3aeab572a074ef645c8/src/mscorlib/shared/System/IO/Path.Unix.cs#L153
See single file publish on Linux (Uses
/var/tmp/as first fallback):https://github.com/dotnet/core-setup/blob/074c3bece80ca300e2f9d053b18748b6537d6f67/src/corehost/common/pal.unix.cpp#L306
Everything is great when TMPDIR is configured, but if not then fallback-paths doesn't match.
Resolves #3899