-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix escaping nested close brackets when parsing layout renderers #3260
Fix escaping nested close brackets when parsing layout renderers #3260
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3260 +/- ##
=====================================
Coverage ? 80%
=====================================
Files ? 355
Lines ? 27986
Branches ? 3727
=====================================
Hits ? 22310
Misses ? 4602
Partials ? 1074 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
[InlineData(@" ${cached:${cached:${literal:text={0\} {1\}}}}")] | ||
[InlineData(@" ${cached:${cached:${cached:${literal:text={0\} {1\}}}}}")] | ||
[InlineData(@"${cached:${cached:${cached:${cached:${literal:text={0\} {1\}}}}}}")] | ||
public void Issue_3193_Nested_Сlosing_Braces(string input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the included tests!
Unfortunately it's a bit hard to follow. We are trying to use AAA in unit tests,see https://www.c-sharpcorner.com/UploadFile/dacca2/fundamental-of-unit-testing-understand-aaa-in-unit-testing/
} | ||
else | ||
{ | ||
throw new Xunit.Sdk.XunitException("NOT SUPPORTED"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this assert.Fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For NUnit - yes
NUnit.Framework.Assert.Fail("..")
https://stackoverflow.com/questions/14631923/cannot-find-assert-fail-and-assert-pass-or-equivalent
Any idea if this will fix also #2844 |
Oooo, this is exciting, I'll have to try this out. I never properly solved the problem I was having, but I notice a few other items referencing the issue #2844 and as @lobster2012-user can't reproduce it, it may well be that it's been fixed. I'll have another try and let you know. |
(I moved comment) |
I think that's better, as the test is "acting" on SimpleLayout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks!
fixes #3193