Feature/cancel reservations #795
Conversation
…ect-schrodinger into feature/library-rooms
…chrodinger into feature/cancel-reservations
jlcrodrigues
force-pushed
the
feature/cancel-reservations
branch
from
a257efe
to
e6492a5
Compare
jlcrodrigues
changed the base branch from
feature/library-reservations
to
develop
|
I've changed the target and this will now be merged to |
| Map<String, String> months = { | ||
| 'Janeiro': '01', | ||
| 'Fevereiro': '02', | ||
| 'Março': '03', | ||
| 'Abril': '04', | ||
| 'Maio': '05', | ||
| 'Junho': '06', | ||
| 'Julho': '07', | ||
| 'Agosto': '08', | ||
| 'Setembro': '09', | ||
| 'Outubro': '10', | ||
| 'Novembro': '11', | ||
| 'Dezembro': '12', | ||
| }; |
|
|
||
| Future<bool> cancelReservation(Session session, String id) async { | ||
| final url = | ||
| // ignore: lines_longer_than_80_chars |
There was a problem hiding this comment.
You can split the string, no need for this
| navLibraryOccupation('biblioteca', faculties: {'feup'}), | ||
| navLibraryReservations('reservas', faculties: {'feup'}), |
There was a problem hiding this comment.
Why does this need to be here? Isn't this on the same page?
There was a problem hiding this comment.
I created a different route for each tab. I am using this for each card's onClick
| '/${DrawerItem.navLibraryReservations.title}', | ||
| ); |
There was a problem hiding this comment.
Should clicking the card redirect to reservations?
There was a problem hiding this comment.
Yes, it has been fixed
| late final String hoursStart; | ||
| late final String hoursEnd; | ||
| late final String weekDay; | ||
| late final String day; | ||
| late final String month; |
There was a problem hiding this comment.
Prefer to use DateTime and display as you wish below. Also, I don't think this needs to be final
…o feature/library-reservations
…oject-schrodinger into feature/cancel-reservations
| // TO DO: Implement parsers for all faculties | ||
| // and dispatch for different fetchers |
There was a problem hiding this comment.
This feature is specific to FEUP, it seems, so is there a need to implement parsers for all faculties?
There was a problem hiding this comment.
Makes sense, I removed the comment in #1073
| "@library_reservations": {}, | ||
| "library_tab_occupation": "Occupation", | ||
| "@library_tab_occupation": {}, | ||
| "library_tab_reservations": "Reservations", |
There was a problem hiding this comment.
Can we think of a better translation, maybe? The original one is "Gabinetes".
There was a problem hiding this comment.
I just saw that SIGARRA doesn't have a translation for this as well... We can leave it like this!
niaefeup-admin
force-pushed
the
develop
branch
from
417c250
to
bd61b50
Compare
Closes #656
Depends on #658 , #1073
Added functionality to cancel library reservations.
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change