Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proguard-rules.pro to include concurrent annotations #1250

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

LuisDuarte1
Copy link
Member

For some reason javax.annotation.concurrent is not covered by javax.annotation.*

For some reason `javax.annotation.concurrent` is not covered by `javax.annotation.*`
@LuisDuarte1 LuisDuarte1 requested a review from a team June 25, 2024 10:30
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17%. Comparing base (5775214) to head (5b6a022).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1250   +/-   ##
=======================================
  Coverage       17%     17%           
=======================================
  Files          229     229           
  Lines         6965    6965           
=======================================
  Hits          1149    1149           
  Misses        5816    5816           

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not working, the flutter build command

* What went wrong:
Execution failed for task ':app:packageRelease'.
> A failure occurred while executing com.android.build.gradle.tasks.PackageAndroidArtifact$IncrementalSplitterRunnable
   > SigningConfig "release" is missing required property "storeFile".

@limwa
Copy link
Member

limwa commented Jun 25, 2024

Still not working, the flutter build command

* What went wrong:
Execution failed for task ':app:packageRelease'.
> A failure occurred while executing com.android.build.gradle.tasks.PackageAndroidArtifact$IncrementalSplitterRunnable
   > SigningConfig "release" is missing required property "storeFile".

Do you have the keystore on your PC?

@LuisDuarte1
Copy link
Member Author

Still not working, the flutter build command

* What went wrong:
Execution failed for task ':app:packageRelease'.
> A failure occurred while executing com.android.build.gradle.tasks.PackageAndroidArtifact$IncrementalSplitterRunnable
   > SigningConfig "release" is missing required property "storeFile".

you might have to make a keystore or I think you can temporarily remove the signing config override in build.gradle.

@LuisDuarte1 LuisDuarte1 dismissed thePeras’s stale review June 25, 2024 14:31

Not applicable to the PR

Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to build it successfully 👍

@DGoiana DGoiana merged commit ad5568e into develop Jun 25, 2024
6 checks passed
@DGoiana DGoiana deleted the fix/proguard-warnings-1 branch June 25, 2024 22:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants