Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add weekend schedule #1172

Merged
merged 3 commits into from
Feb 29, 2024
Merged

fix: add weekend schedule #1172

merged 3 commits into from
Feb 29, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Feb 29, 2024

Closes #946.

Supersedes #1039.

In this PR, a tab for Saturday is added. Furthermore, a new translation for no classes on weekends is also added.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #1172 (a5ad009) into develop (2d0c6c2) will increase coverage by 1%.
Report is 2 commits behind head on develop.
The diff coverage is 92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1172   +/-   ##
=======================================
+ Coverage       15%     15%   +1%     
=======================================
  Files          228     228           
  Lines         6899    6907    +8     
=======================================
+ Hits          1020    1027    +7     
- Misses        5879    5880    +1     

@bdmendes bdmendes mentioned this pull request Feb 29, 2024
7 tasks
@limwa limwa enabled auto-merge February 29, 2024 13:48
@bdmendes bdmendes added this to the March 2023 Release milestone Feb 29, 2024
@limwa limwa requested a review from a team February 29, 2024 15:43
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@limwa limwa merged commit 69a53e0 into develop Feb 29, 2024
6 checks passed
@limwa limwa deleted the limwa/fix/weekend-schedule branch February 29, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show weekend tabs on schedule page
3 participants