Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile button is no longer clipped on navbar #1154

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Feb 25, 2024

This PR fixes an issue with the profile button in the navbar.

The clipping occurred because the profile button had padding on the bottom, which made it move up and overflow.

I took this opportunity to extract a component called ProfileImage. Also, a CircleAvatar was used instead of a box decoration.

This also fixes a issue overlooked in the #1152 where the settings icon in the profile page had too much padding on the right.

Screenrecording

uni-fix-profile-button-overflow.mp4

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@limwa limwa requested a review from a team February 25, 2024 01:29
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Merging #1154 (168bba7) into develop (94bcf02) will increase coverage by 1%.
Report is 2 commits behind head on develop.
The diff coverage is 11%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1154   +/-   ##
=======================================
+ Coverage       16%     16%   +1%     
=======================================
  Files          227     228    +1     
  Lines         6862    6848   -14     
=======================================
+ Hits          1073    1075    +2     
+ Misses        5789    5773   -16     

Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LuisDuarte1 LuisDuarte1 merged commit 063b6bb into develop Feb 25, 2024
6 checks passed
@LuisDuarte1 LuisDuarte1 deleted the limwa/fix/profile-button-clipped-on-navbar branch February 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants