fix: profile button is no longer clipped on navbar #1154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the profile button in the navbar.
The clipping occurred because the profile button had padding on the bottom, which made it move up and overflow.
I took this opportunity to extract a component called ProfileImage. Also, a CircleAvatar was used instead of a box decoration.
This also fixes a issue overlooked in the #1152 where the settings icon in the profile page had too much padding on the right.
Screenrecording
uni-fix-profile-button-overflow.mp4
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change