Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Parser for different faculties #1096

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Fix Parser for different faculties #1096

merged 3 commits into from
Feb 9, 2024

Conversation

rubuy-74
Copy link
Contributor

Closes #800
In Sigarra's exams page for FCUP and other faculties, some exams have their begin and end times in a different format, not previously supported by the Exams Parser.

image

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@rubuy-74 rubuy-74 force-pushed the fix/exams-page branch 3 times, most recently from ba20630 to 64cd0f1 Compare February 7, 2024 15:15
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #1096 (d119a8b) into develop (66fcc86) will decrease coverage by 0%.
Report is 91 commits behind head on develop.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #1096    +/-   ##
========================================
- Coverage       17%     16%    -0%     
========================================
  Files          212     220     +8     
  Lines         6472    6672   +200     
========================================
+ Hits          1044    1056    +12     
- Misses        5428    5616   +188     

@thePeras thePeras marked this pull request as ready for review February 7, 2024 15:44
@rubuy-74 rubuy-74 force-pushed the fix/exams-page branch 2 times, most recently from c6c5802 to d119a8b Compare February 9, 2024 14:14
@bdmendes bdmendes merged commit 8621062 into develop Feb 9, 2024
5 checks passed
@bdmendes bdmendes deleted the fix/exams-page branch February 9, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix data unavailable issues for faculties outside FEUP
4 participants