Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto-serialization #1072

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Conversation

rubuy-74
Copy link
Contributor

Closes #662.
Continues the work started in #837.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: Patch coverage is 13.04348% with 100 lines in your changes missing coverage. Please review.

Project coverage is 16%. Comparing base (aed0bfc) to head (a53c0e9).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1072   +/-   ##
=======================================
+ Coverage       16%     16%   +1%     
=======================================
  Files          233     234    +1     
  Lines         7293    7235   -58     
=======================================
+ Hits          1139    1140    +1     
+ Misses        6154    6095   -59     

@thePeras
Copy link
Member

Not looking into the code now, I noticed the amount of files generated by the package.
We can reduce into one .g.dart file if we follow this approach with a _models.dart file.

Declarate a library with the json annotation import as well all the parts of all of the models and in each model file include part of <library_name>;
Running the command again, will generate only one _models.g.dart file.

Feel free to follow or not this idea.

uni/lib/model/entities/bug_report.dart Outdated Show resolved Hide resolved
uni/lib/model/entities/course.dart Outdated Show resolved Hide resolved
uni/lib/model/entities/course.dart Show resolved Hide resolved
uni/lib/model/entities/exam.dart Outdated Show resolved Hide resolved
uni/lib/model/entities/lecture.dart Outdated Show resolved Hide resolved
@bdmendes bdmendes mentioned this pull request Dec 26, 2023
7 tasks
@rubuy-74 rubuy-74 force-pushed the feature/json-serialization branch 3 times, most recently from 129137b to 2f37506 Compare January 5, 2024 15:08
@thePeras thePeras requested a review from bdmendes January 5, 2024 15:17
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have the chance to test this properly, but looking at the code seems all fine!

@bdmendes bdmendes self-requested a review January 12, 2024 14:16
@bdmendes bdmendes requested a review from a team January 26, 2024 14:40
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error in my account:
image
Does this help?

@bdmendes bdmendes requested a review from a team March 6, 2024 14:29
@bdmendes
Copy link
Member

@rubuy-74 can you rebase this?

@bdmendes bdmendes added this to the July 2024 Release milestone May 22, 2024
@rubuy-74 rubuy-74 force-pushed the feature/json-serialization branch from ac8ba1a to 6bdbff1 Compare May 29, 2024 14:19
@rubuy-74 rubuy-74 force-pushed the feature/json-serialization branch from 6bdbff1 to d1cc8b1 Compare May 29, 2024 14:26
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, please fix the linting and address some issues below 🚀

uni/lib/model/entities/course.dart Show resolved Hide resolved
uni/lib/model/entities/bug_report.dart Outdated Show resolved Hide resolved
uni/lib/model/entities/exam.dart Outdated Show resolved Hide resolved
uni/lib/model/entities/lecture.dart Outdated Show resolved Hide resolved
uni/lib/model/entities/meal.dart Outdated Show resolved Hide resolved
uni/lib/model/entities/meal.dart Show resolved Hide resolved
uni/lib/model/entities/reference.dart Show resolved Hide resolved
@rubuy-74 rubuy-74 force-pushed the feature/json-serialization branch 3 times, most recently from 8af5ad2 to f2b4916 Compare June 5, 2024 16:03
@rubuy-74 rubuy-74 force-pushed the feature/json-serialization branch from f2b4916 to 7a78e8a Compare June 5, 2024 17:40
@DGoiana DGoiana enabled auto-merge July 5, 2024 22:57
@DGoiana DGoiana disabled auto-merge July 5, 2024 23:07
@rubuy-74 rubuy-74 dismissed bdmendes’s stale review July 5, 2024 23:15

Non-active member.

@rubuy-74 rubuy-74 dismissed LuisDuarte1’s stale review July 15, 2024 13:48

Urgency on changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use auto serialization options for storage purposes
5 participants