Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Tooltip Added in add Restaurant card action. #1050

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Feature] Tooltip Added in add Restaurant card action. #1050

wants to merge 1 commit into from

Conversation

NishchayShakya1
Copy link
Contributor

Closes #1013

  • Added 'Add to Personal Area' in tooltip.
  • Added this to i18n and used "Adicionar à Àrea Pessoal" as the Portuguese equivalent.

Review checklist

  • Behavior is as expected
  • Clean, well-structured code

@NishchayShakya1 NishchayShakya1 mentioned this pull request Dec 10, 2023
Closed
2 tasks
thePeras
thePeras requested changes Dec 24, 2023
View reviewed changes
uni/lib/generated/intl/messages_pt_PT.dart
@@ -246,6 +246,7 @@ class MessageLookup extends MessageLookupByLibrary {
"widget_prompt": MessageLookupByLibrary.simpleMessage(
"Escolhe um widget para adicionares à tua área pessoal:"),
"year": MessageLookupByLibrary.simpleMessage("Ano"),
"yes": MessageLookupByLibrary.simpleMessage("Sim")
"yes": MessageLookupByLibrary.simpleMessage("Sim"),
"tooltip":MessageLookupByLibrary.simpleMessage("Adicionar à Àrea Pessoal")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two things:

  • Make it a clear name, not only tooltip, add something more.
  • It is à Área, not à Àrea

@bdmendes bdmendes marked this pull request as draft December 25, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tooltip in add Restaurant card action
2 participants
@NishchayShakya1 @thePeras