Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate Url Launch with Toast #1005

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Encapsulate Url Launch with Toast #1005

merged 1 commit into from
Oct 11, 2023

Conversation

rubuy-74
Copy link
Contributor

@rubuy-74 rubuy-74 commented Oct 6, 2023

Closes #544
Method that checks if the user's device can open a link (canLaunchUrl) and displays an toastMessage error if it can't.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@rubuy-74 rubuy-74 mentioned this pull request Oct 6, 2023
7 tasks
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1005 (0b5ff94) into develop (226465f) will decrease coverage by 0%.
Report is 1 commits behind head on develop.
The diff coverage is 6%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1005   +/-   ##
=======================================
- Coverage       16%     16%   -0%     
=======================================
  Files          201     202    +1     
  Lines         6361    6371   +10     
=======================================
  Hits           986     986           
- Misses        5375    5385   +10     

Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@bdmendes bdmendes merged commit 1ce1027 into develop Oct 11, 2023
6 checks passed
@bdmendes bdmendes deleted the feature/url-toast branch October 11, 2023 11:08
@bdmendes bdmendes mentioned this pull request Dec 8, 2023
7 tasks
@bdmendes bdmendes mentioned this pull request Jan 5, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't launch url ToastMessage error
3 participants