Update clang format version + cmake format + minor warnings fixes #229

jrmadsen · 2021-09-29T19:10:42Z

updated clang-format from v6 to v9
- this resulted in a lot of whitespace changes
updated workflows using (deprecated) ubuntu-16.04 to use ubuntu-20.04
added cmake-format workflow
removed use of TIMEMORY_NOCLONE
removed overloads of new and delete in singleton class
- caused mismatched new/delete warnings in GCC 11

- clang-format v9 - cmake-format - formatting workflow

- Removed TIMEMORY_NOCLONE usage - Removed new/delete overloads from singleton (warnings)

PointKernel · 2021-09-29T19:55:37Z

Have to say, cmake-format is still a bit ugly.

jrmadsen · 2021-09-29T19:59:47Z

Haha, yeah I don't really disagree. It is a relatively primitive tool at this point but at least it helps making things consistent.

jrmadsen force-pushed the update-clang-format-version branch 2 times, most recently from ec86c39 to 4ab1eaf Compare September 29, 2021 19:17

jrmadsen added 4 commits September 29, 2021 14:24

Updated formatting

69cefce

- clang-format v9 - cmake-format - formatting workflow

Apply cmake-format

d33428d

Apply clang-format v9

5813eaa

Warnings cleanup

ec78400

- Removed TIMEMORY_NOCLONE usage - Removed new/delete overloads from singleton (warnings)

jrmadsen force-pushed the update-clang-format-version branch from 4ab1eaf to ec78400 Compare September 29, 2021 19:24

jrmadsen merged commit b13a58d into develop Sep 29, 2021

jrmadsen deleted the update-clang-format-version branch September 29, 2021 19:26

Provide feedback