Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close /proc/meminfo at exit #89

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Close /proc/meminfo at exit #89

merged 3 commits into from
Jun 17, 2020

Conversation

davidhassell
Copy link
Collaborator

Fixes #88

@davidhassell davidhassell mentioned this pull request Jun 17, 2020
Closed
sadielbartholomew
sadielbartholomew approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works a charm! (Have not heard of atexit before but it seem exactly what was needed. Cool.) I tested with python -X dev test_dsg.py as well as without -X dev to ensure the ResourceWarning would emerge in case it might be hidden & in both cases it has gone relative to a run on master branch.

The GH Actions run indicates the change does not have undesired influence elsewhere since it the 3.8 Ubuntu job passes except for the test_pp_* which are unrelated (& I think I have sorted over on the PR #87, which I plan to message you about there) & two PEP8 instances picked up on in the workflow but they can always be addressed later:

 2020-06-17T08:41:54.5379381Z ../functions.py:71:1: W293 blank line contains whitespace
2020-06-17T08:41:54.5379608Z ../functions.py:75:1: E302 expected 2 blank lines, found 1
2020-06-17T08:42:01.2490112Z test_pep8_compliance (test_style.styleTest) ... FAIL

@sadielbartholomew sadielbartholomew merged commit 0c4ec40 into NCAS-CMS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/proc/meminfo left open by functions module (GNU/Linux)
2 participants
@davidhassell @sadielbartholomew