Include the UM version as a field property when reading UM files #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhassell
added
enhancement
sadielbartholomew
approved these changes
Jun 3, 2024
| # Convert the UM version to a string and provide it as a | ||
| # CF property. E.g. 405 -> '4.5', 606.3 -> '6.6.3', 1002 | ||
| # -> '10.2' | ||
| a, b = divmod(int(self.um_version), 100) |
There was a problem hiding this comment.
I was wondering why, for the fraction component, you didn't just accept the raw numeric and then seeing this I realise it is to do with the floating point conversion:
>>> divmod(606.3, 100)
(6.0, 6.2999999999999545)Might be worth a one-line comment, since I was curious enough to look into that?
There was a problem hiding this comment.
Good idea: b0119f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #777
Changes to:
are not relevant to this PR, but are just some linting that crept in from somewhere else.