Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in cf.aggregate that sometimes put a null transpose operation into the Dask grpah when one was not needed #755

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix bug in cf.aggregate that sometimes put a null transpose operation into the Dask grpah when one was not needed #755

merged 1 commit into from
Apr 4, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #754

@davidhassell davidhassell added bug Something isn't working performance Relating to speed and memory performance active storage Relating to active storage operations labels Apr 3, 2024
@davidhassell davidhassell added this to the Next release milestone Apr 3, 2024
sadielbartholomew
sadielbartholomew approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot and fix. I've sanity checked, so please merge.

@davidhassell davidhassell merged commit b2d4439 into NCAS-CMS:main Apr 4, 2024
3 of 4 checks passed
@davidhassell davidhassell deleted the aggregate-transpose branch April 4, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
active storage Relating to active storage operations bug Something isn't working performance Relating to speed and memory performance
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.

cf.aggregate sometimes needlessly puts in a "transpose" layer into the Dask graph
2 participants
@davidhassell @sadielbartholomew