Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of reading and accessing the data of PP and UM fields files #747

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Improve the performance of reading and accessing the data of PP and UM fields files #747

merged 10 commits into from
Mar 26, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #746

@davidhassell davidhassell added bug Something isn't working performance Relating to speed and memory performance labels Mar 23, 2024
@davidhassell davidhassell added this to the Next release milestone Mar 23, 2024
sadielbartholomew
sadielbartholomew approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff! I have checked timings with some hefty .pp files and array access is indeed much quicker. I've raised some minor comments about the code changes, but I'm happy overall so please merge once you feel ready.

cf/data/array/umarray.py Show resolved Hide resolved
cf/test/test_read_write.py Outdated Show resolved Hide resolved
cf/read_write/um/umread.py Show resolved Hide resolved
@davidhassell @sadielbartholomew
unit test skip message
45497ec 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit e94f82a into NCAS-CMS:main Mar 26, 2024
@sadielbartholomew sadielbartholomew mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working performance Relating to speed and memory performance
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.

Improve the performance of reading and accessing the data of PP and UM fields files
2 participants
@davidhassell @sadielbartholomew