Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when calculating UGRID cell areas when non-spatial coordinates span the discrete axis #722

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #721

No unit test - due to the lightly random nature, it's a bit tricky to write one. But the fix is pretty simple and it works for the use case described in the issue :)

@davidhassell davidhassell added bug Something isn't working UGRID Relating to UGRID mesh topologies labels Feb 22, 2024
@davidhassell davidhassell added this to the 3.17.0 milestone Feb 22, 2024
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One amendment required, but that should be all. Let me know what you think.

cf/weights.py Outdated Show resolved Hide resolved
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit e3183da into NCAS-CMS:main Feb 23, 2024
@davidhassell davidhassell deleted the ugrid-weights branch February 23, 2024 16:47
@davidhassell davidhassell restored the ugrid-weights branch February 23, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UGRID Relating to UGRID mesh topologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug when calculating UGRID cell areas when non-spatial coordinates span the discrete axis
2 participants