Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cf.Field.collapse: Fix "sum", "sum_of_weights" and "sum_of_weights2" when weighted #702

Merged
merged 3 commits into from
Oct 23, 2023
Merged

cf.Field.collapse: Fix "sum", "sum_of_weights" and "sum_of_weights2" when weighted #702

merged 3 commits into from
Oct 23, 2023

Conversation

davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Oct 20, 2023 •
edited
Loading

Fixes #701

The crux of the issue was that "sum", "sum_of_weights" and "sum_of_weights2" were missing from the cf.field._collapse_weighted_methods set.

@davidhassell davidhassell added the bug Something isn't working label Oct 20, 2023
@davidhassell davidhassell added this to the Next release milestone Oct 20, 2023
@davidhassell davidhassell changed the title cf.Field.collapse: Fix "sum" and "sum_of_weights" and "sum_of_weights2" when weighted cf.Field.collapse: Fix "sum", "sum_of_weights" and "sum_of_weights2" when weighted Oct 20, 2023
sadielbartholomew
sadielbartholomew approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue at hand and adds some thorough new testing covering the collapse methods in question. All good, please merge.

@davidhassell davidhassell merged commit 1668e0b into NCAS-CMS:main Oct 23, 2023
5 of 9 checks passed
@davidhassell davidhassell deleted the weighted-sum branch October 23, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

cf.Field.collapse: sum, sum_of_weights and sum_of_weights2 incorrect when weighted
2 participants
@davidhassell @sadielbartholomew