Minor changes to read.py #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
commented
Oct 31, 2019
cf/read_write/read.py
Outdated
| @@ -540,8 +540,6 @@ def read(files, external=None, verbose=False, warnings=False, | |||
| if aggregate and len(field_list) > 1: | |||
| if verbose: | |||
| org_len = len(field_list) # pragma: no cover | |||
|
|
|||
| if verbose: | |||
| @@ -598,7 +596,7 @@ def _plural(n): # pragma: no cover | |||
| return 's' if n !=1 else '' # pragma: no cover | |||
|
|
|||
|
|
|||
| def _read_a_file(filename, aggregate=True, aggregate_options={}, | |||
| def _read_a_file(filename, aggregate=True, aggregate_options=None, | |||
There was a problem hiding this comment.
| @@ -630,6 +628,8 @@ def _read_a_file(filename, aggregate=True, aggregate_options={}, | |||
| The fields in the file. | |||
|
|
|||
| ''' | |||
| if aggregate_options is None: | |||
| aggregate_options = {} | |||
There was a problem hiding this comment.
Part of the removal of the default mutable argument above.
| if ftype == 'CDL': | ||
| # Create a temporary netCDF file from input CDL | ||
| cdl = True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Starting reading the code from the
readfunction in theREADME.mdexample. This PR changes a few things in the code that should not affect the behaviour, but simplify the code or protect against possible issues.