Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with captions of certain tutorials #533

Merged
merged 8 commits into from
Dec 20, 2022

Conversation

bewithankit
Copy link
Contributor

Fixes #529

Copy link
Collaborator

@davidhassell davidhassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ankit - thank you for spotting these defects and fixing them!

I've made a few suggestions for you to consider - the main thing being the ordinal numbers were out by 1 :)

docs/source/tutorial.rst Outdated Show resolved Hide resolved
docs/source/tutorial.rst Outdated Show resolved Hide resolved
docs/source/tutorial.rst Outdated Show resolved Hide resolved
docs/source/tutorial.rst Outdated Show resolved Hide resolved
docs/source/tutorial.rst Outdated Show resolved Hide resolved
docs/source/tutorial.rst Outdated Show resolved Hide resolved
docs/source/tutorial.rst Outdated Show resolved Hide resolved
@bewithankit
Copy link
Contributor Author

bewithankit commented Dec 20, 2022

Ah, the ordinal numbers! Thank you David! 🤝
Are we good to merge the pull request now?

@bewithankit bewithankit merged commit 8c8dcea into NCAS-CMS:master Dec 20, 2022
@davidhassell davidhassell added this to the 3.14.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with captions of some tutorials
2 participants