Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify comparisons #5

Closed
wants to merge 2 commits into from
Closed

Simplify comparisons #5

wants to merge 2 commits into from

Conversation

kinow
Copy link
Contributor

@kinow kinow commented Oct 25, 2019

This PR replaces var == True by a simple var test, and also uses is None instead of == None (see ref)

@davidhassell
Copy link
Collaborator

Hi,

I won't merge this, not because I disagree with it (on the contrary), but because it highlighted a slight change in the functionality that was needed in cf.functions._section, and it was easy to implement all of the other is None changes by hand, as there weren't many of them.

Many thanks

davidhassell added a commit that referenced this pull request Oct 25, 2019
@kinow
Copy link
Contributor Author

kinow commented Oct 25, 2019

Thanks @davidhassell ! Some tests were failing in my environment (before the change too), so I couldn't confirm what exactly would be impacted by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants