Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.chunks and Data.rechunk #355

Merged
merged 3 commits into from
Mar 15, 2022
Merged

dask: Data.chunks and Data.rechunk #355

merged 3 commits into from
Mar 15, 2022

Conversation

davidhassell
Copy link
Collaborator

Just docs and tests. Code changes were already there.

@davidhassell davidhassell added the dask Relating to the use of Dask label Mar 11, 2022
@davidhassell davidhassell mentioned this pull request Mar 11, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

Code changes were already there.

I also did some manual testing on the code you migrated previously and it is watertight, as the new test helps to confirm.

Merge at will.

cf/data/data.py Outdated Show resolved Hide resolved
cf/data/data.py Show resolved Hide resolved
cf/data/data.py Outdated Show resolved Hide resolved
davidhassell and others added 2 commits March 15, 2022 08:16
@davidhassell @sadielbartholomew
Typo
1217520 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell @sadielbartholomew
Typo
9faeef6 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit 7eb8aa5 into NCAS-CMS:lama-to-dask Mar 15, 2022
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidhassell @sadielbartholomew