Fixes setting both relaxed_identities=True and ncvar_identities=True in cf.aggregate
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Fixes the issue at hand in a sensible way, adding a new test which exposes the original issue. The CI job failures are unrelated, due to a single flaky test which I have registered in a new issue (#348), and can be considered passes when that is taken into consideration.
Excellent! Merge at will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341
Fixes the issue, and a bit of code tidy thrown in that resulted from a red herring that I pursued before properly understanding the requirements.