Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cf.aggregate failures when using the 'dimension' keyword #284

Merged

Conversation

davidhassell
Copy link
Collaborator

Fixes #283

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment (see in-line), otherwise all good:

This is simply a bug in code that was not covered by the units tests.

Bug fixed and a new unit test added which captures the bug (fails on the current master and not here).

cf/aggregate.py Show resolved Hide resolved
@sadielbartholomew
Copy link
Member

Note that the CI test failures are both solely due to the following error:

FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/cf-python/cf-python/main/cf/test/test_file.nc'

so somehow the given test file is not being generated. I will look into that separately. Merging now.

@sadielbartholomew sadielbartholomew merged commit fd87907 into NCAS-CMS:master Dec 3, 2021
@davidhassell davidhassell added this to the 3.12.0 milestone Jan 4, 2022
@davidhassell davidhassell added the bug Something isn't working label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cf.aggregate fails when creating new axes with the dimension keyword
2 participants